Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(947)

Issue 2684623002: [WIP] Move ownership of PlatformDisplay from ws::Display to ws::WindowServer (Closed)

Created:
1 year ago by fwang
Modified:
1 year ago
Reviewers:
kylechar, tonikitoo
CC:
chromium-reviews, rjkroege, Fady Samuel, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ownership of PlatformDisplay from ws::Display to ws::WindowServer In mash mode, an instance of ws::PlatformDisplay used for a drawable root window is currently owned by ws::Display which means we have to create a new display for each platform window. This works well for the "internal window mode" used by Chrome OS (a single drawable surface for the whole display). However, for "external window mode" (any number of plaform windows, each with their own drawable surface) the top level Chrome ServerWindows need to own ws::PlatformDisplay. This CL thus moves ownership of PlatformDisplay from ws::Display to ws::WindowServer. BUG=666958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M services/ui/ws/display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/ws/display.cc View 2 chunks +7 lines, -1 line 0 comments Download
M services/ui/ws/window_server.h View 3 chunks +6 lines, -0 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
fwang
I'm not sure we have an agreement on how to implement external window mode precisely. ...
1 year ago (2017-02-07 16:27:27 UTC) #2
kylechar
On 2017/02/07 16:27:27, fwang wrote: > I'm not sure we have an agreement on how ...
1 year ago (2017-02-08 14:28:17 UTC) #8
kylechar
On 2017/02/08 14:28:17, kylechar wrote: > On 2017/02/07 16:27:27, fwang wrote: > > I'm not ...
1 year ago (2017-02-09 18:03:05 UTC) #9
fwang
1 year ago (2017-02-16 08:42:00 UTC) #10
Yes, I believe we can just continue to create an ws::Display (maybe renaming it)
for each external window. Closing this.

Powered by Google App Engine
This is Rietveld 408576698