Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Currently, starting and ending selections are defined for all EditCommand,
but are used by only CompositeEditCommand; SimpleEditCommand does not use
them.

Hence, this patch moves the two selections from EditCommand to
CompositeEditCommand, so that the construction of SimpleCommand becomes
simpler.

As EditCommand::setParent modifies starting and ending selection, this
patch turns it into a virtual function, and overrides it with
CompositeEditCommand::setParent to modify the selections.

This patch also removes a redundant static function undoStepIfPossible()
from EditCommand.cpp.

BUG=682137
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2641803002
Cr-Commit-Position: refs/heads/master@{#444338}
Committed: https://chromium.googlesource.com/chromium/src/+/d9e076c4780e0bcb4af6a257407f006c44a3a976

[Xiaocheng, 2017-01-18 09:23:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 09:23:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-18 09:39:01]

Description was changed from

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

BUG=682137
==========

to

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Currently, starting and ending selections are defined for all EditCommand,
but are used by only CompositeEditCommand; SimpleEditCommand does not use
them.

Hence, this patch moves the two selections from EditCommand to
CompositeEditCommand, so that the construction of SimpleCommand becomes
simpler.

As EditCommand::setParent modifies starting and ending selection, this
patch turns it into a virtual function, and overrides it with
CompositeEditCommand::setParent to modify the selections.

This patch also removes a redundant static function undoStepIfPossible().

BUG=682137
TEST=n/a; no behavior change
==========

[Xiaocheng, 2017-01-18 09:39:16]

Description was changed from

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Currently, starting and ending selections are defined for all EditCommand,
but are used by only CompositeEditCommand; SimpleEditCommand does not use
them.

Hence, this patch moves the two selections from EditCommand to
CompositeEditCommand, so that the construction of SimpleCommand becomes
simpler.

As EditCommand::setParent modifies starting and ending selection, this
patch turns it into a virtual function, and overrides it with
CompositeEditCommand::setParent to modify the selections.

This patch also removes a redundant static function undoStepIfPossible().

BUG=682137
TEST=n/a; no behavior change
==========

to

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Currently, starting and ending selections are defined for all EditCommand,
but are used by only CompositeEditCommand; SimpleEditCommand does not use
them.

Hence, this patch moves the two selections from EditCommand to
CompositeEditCommand, so that the construction of SimpleCommand becomes
simpler.

As EditCommand::setParent modifies starting and ending selection, this
patch turns it into a virtual function, and overrides it with
CompositeEditCommand::setParent to modify the selections.

This patch also removes a redundant static function undoStepIfPossible()
from EditCommand.cpp.

BUG=682137
TEST=n/a; no behavior change
==========

[Xiaocheng, 2017-01-18 10:07:38]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-01-18 10:07:38]

PTAL.

[commit-bot: I haz the power, 2017-01-18 10:50:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 10:50:26]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-18 12:09:32]

lgtm

Thanks for quick work!
(^_^)b

[yosin_UTC9, 2017-01-18 12:09:52]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:10:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 12:13:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484741392156800, "parent_rev":
"e6e31527e9ace8760b0b89f738098d8dbf6d12cb", "commit_rev":
"d9e076c4780e0bcb4af6a257407f006c44a3a976"}

[commit-bot: I haz the power, 2017-01-18 12:13:48]

Description was changed from

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Currently, starting and ending selections are defined for all EditCommand,
but are used by only CompositeEditCommand; SimpleEditCommand does not use
them.

Hence, this patch moves the two selections from EditCommand to
CompositeEditCommand, so that the construction of SimpleCommand becomes
simpler.

As EditCommand::setParent modifies starting and ending selection, this
patch turns it into a virtual function, and overrides it with
CompositeEditCommand::setParent to modify the selections.

This patch also removes a redundant static function undoStepIfPossible()
from EditCommand.cpp.

BUG=682137
TEST=n/a; no behavior change
==========

to

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2)

Currently, starting and ending selections are defined for all EditCommand,
but are used by only CompositeEditCommand; SimpleEditCommand does not use
them.

Hence, this patch moves the two selections from EditCommand to
CompositeEditCommand, so that the construction of SimpleCommand becomes
simpler.

As EditCommand::setParent modifies starting and ending selection, this
patch turns it into a virtual function, and overrides it with
CompositeEditCommand::setParent to modify the selections.

This patch also removes a redundant static function undoStepIfPossible()
from EditCommand.cpp.

BUG=682137
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2641803002
Cr-Commit-Position: refs/heads/master@{#444338}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9e076c4780e0bcb4af6a257407f...
==========

[commit-bot: I haz the power, 2017-01-18 12:13:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9e076c4780e0bcb4af6a257407f...