Move EditCommand::starting/endingSelection() to CompositeEditCommand (2/2)

Move EditCommand::starting/endingSelection() to CompositeEditCommand (2/2)

BUG=682137
Review-Url: https://codereview.chromium.org/2645453002
Cr-Commit-Position: refs/heads/master@{#444587}
Committed: https://chromium.googlesource.com/chromium/src/+/2742a8b3bdc414e596a9382a3b6959c0c4e95f93

[Xiaocheng, 2017-01-18 09:26:32]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 09:26:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-01-18 10:07:50]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-01-18 10:07:50]

PTAL.

[yosin_UTC9, 2017-01-18 12:17:02]

lgtm w/ nit

https://codereview.chromium.org/2645453002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2645453002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:1977:
if (parent) {
nit: let's use early return pattern to avoid indentation.

if (!parent)
  return;
m_startingSelection = parent->m_endingSelection;
m_endingSelection = parent->m_endingSelection;

[commit-bot: I haz the power, 2017-01-18 12:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:38:06]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-01-18 22:20:49]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-01-18 22:20:49]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2645453002/#ps20001
(title: "Fix nit")

[Xiaocheng, 2017-01-18 22:21:07]

Committing with nit fixed. Thanks for the review.

https://codereview.chromium.org/2645453002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2645453002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:1977:
if (parent) {
On 2017/01/18 at 12:17:02, Yosi_UTC9 wrote:
> nit: let's use early return pattern to avoid indentation.
> 
> if (!parent)
>   return;
> m_startingSelection = parent->m_endingSelection;
> m_endingSelection = parent->m_endingSelection;

Done.

[commit-bot: I haz the power, 2017-01-18 22:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 01:28:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484778049214030,
"parent_rev": "a65f8aef002b29053fcd5ef52d118018c596d1c5", "commit_rev":
"2742a8b3bdc414e596a9382a3b6959c0c4e95f93"}

[commit-bot: I haz the power, 2017-01-19 01:28:42]

Description was changed from

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (2/2)

BUG=682137
==========

to

==========
Move EditCommand::starting/endingSelection() to CompositeEditCommand (2/2)

BUG=682137

Review-Url: https://codereview.chromium.org/2645453002
Cr-Commit-Position: refs/heads/master@{#444587}
Committed:
https://chromium.googlesource.com/chromium/src/+/2742a8b3bdc414e596a9382a3b69...
==========

[commit-bot: I haz the power, 2017-01-19 01:28:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2742a8b3bdc414e596a9382a3b69...