Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2636403002: Clean up names related to EditCommandComposition (Closed)

Created:
3 years, 11 months ago by Xiaocheng
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up names related to EditCommandComposition After renaming class |EditCommandComposition| to |UndoStep|, this patch cleans up the related names: CompositeEditCommand::composition() -> ::undoStep() CompositeEditCommand::ensureComposition() -> ::ensureUndoStep() CompositeEditCommand::appendCommandToComposite() -> :: appendCommandToUndoStep() CompositeEditCommand::m_composition -> ::m_undoStep And some other changes to local variable/function names. BUG=682129 Review-Url: https://codereview.chromium.org/2636403002 Cr-Commit-Position: refs/heads/master@{#444322} Committed: https://chromium.googlesource.com/chromium/src/+/67d2af50c728c4eac309191eaa2d6b4df2f7f718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 2 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditCommand.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Xiaocheng
PTAL.
3 years, 11 months ago (2017-01-18 08:42:53 UTC) #5
yosin_UTC9
lgtm Wonderful! I've not aware them. (^_^;)
3 years, 11 months ago (2017-01-18 08:53:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636403002/1
3 years, 11 months ago (2017-01-18 09:47:17 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 10:06:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/67d2af50c728c4eac309191eaa2d...

Powered by Google App Engine
This is Rietveld 408576698