Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditCommand.h

Issue 2641803002: Move EditCommand::starting/endingSelection() to CompositeEditCommand (1/2) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/EditCommand.h b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
index 34939bc1a28b5aa947b02f3d3c7cb689dd5e0aba..668b52e600a765c6467ed673d1307a7e4982c842 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/EditCommand.h
@@ -41,15 +41,10 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
public:
virtual ~EditCommand();
- void setParent(CompositeEditCommand*);
+ virtual void setParent(CompositeEditCommand*);
virtual InputEvent::InputType inputType() const;
- const VisibleSelection& startingSelection() const {
- return m_startingSelection;
- }
- const VisibleSelection& endingSelection() const { return m_endingSelection; }
-
virtual bool isSimpleEditCommand() const { return false; }
virtual bool isCompositeEditCommand() const { return false; }
bool isTopLevelCommand() const { return !m_parent; }
@@ -67,11 +62,6 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
Document& document() const { return *m_document.get(); }
CompositeEditCommand* parent() const { return m_parent; }
- void setStartingSelection(const VisibleSelection&);
- void setEndingSelection(const SelectionInDOMTree&);
- // TODO(yosin): |setEndingVisibleSelection()| will take |SelectionInUndoStep|
- // You should not use this function other than copying existing selection.
- void setEndingVisibleSelection(const VisibleSelection&);
// TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
// |VisiblePosition::characterAfter()| and
@@ -80,8 +70,6 @@ class CORE_EXPORT EditCommand : public GarbageCollectedFinalized<EditCommand> {
private:
Member<Document> m_document;
- VisibleSelection m_startingSelection;
- VisibleSelection m_endingSelection;
Member<CompositeEditCommand> m_parent;
};

Powered by Google App Engine
This is Rietveld 408576698