Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands (Closed)

Created:
3 years, 11 months ago by Leszek Swirski
Modified:
3 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Expect 'I' for signed bytecode operands Because it was confusing seeing U8(negative value). Review-Url: https://codereview.chromium.org/2640273002 Cr-Commit-Position: refs/heads/master@{#42662} Committed: https://chromium.googlesource.com/v8/v8/+/03a2b3a1a3a37aa36c0b9a744715c607e23807ae

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1480 lines, -1475 lines) Patch
M test/cctest/interpreter/bytecode-expectations-printer.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden View 8 chunks +31 lines, -31 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden View 3 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 17 chunks +75 lines, -75 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden View 6 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallGlobal.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallNew.golden View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 10 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Conditional.golden View 4 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariable.golden View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CountOperators.golden View 8 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeadCodeRemoval.golden View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeclareGlobals.golden View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Delete.golden View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DoExpression.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Eval.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 4 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 16 chunks +32 lines, -32 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GenerateTestUndetectable.golden View 8 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 28 chunks +54 lines, -54 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalCompoundExpressions.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalDelete.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/IfConditions.golden View 12 chunks +25 lines, -25 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/IntegerConstants.golden View 3 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/JumpsRequiringConstantWideOperands.golden View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariable.golden View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden View 12 chunks +287 lines, -287 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlot.golden View 6 chunks +11 lines, -11 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 48 chunks +72 lines, -72 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/NewAndSpread.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 6 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Parameters.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PrimitiveExpressions.golden View 12 chunks +21 lines, -21 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PrimitiveReturnStatements.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyStores.golden View 6 chunks +518 lines, -518 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Switch.golden View 9 chunks +104 lines, -104 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Throw.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryCatch.golden View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryFinally.golden View 9 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Typeof.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden View 7 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WideRegisters.golden View 6 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
Leszek Swirski
Hi Ross, Small QoL CL here, just for something that was bugging me.
3 years, 11 months ago (2017-01-24 20:15:40 UTC) #8
rmcilroy
lgtm
3 years, 11 months ago (2017-01-25 08:47:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640273002/20001
3 years, 11 months ago (2017-01-25 17:37:17 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 17:39:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/03a2b3a1a3a37aa36c0b9a744715c607e23...

Powered by Google App Engine
This is Rietveld 408576698