test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden - Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden

Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden ('k') | test/cctest/interpreter/bytecode_expectations/BasicLoops.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden b/test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden

index 547e83590e71b79a3af6414e17437bd9f9ac65b1..acb9c36ce3f70553b02baf5189e4f54d74910bb9 100644

--- a/test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden

+++ b/test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden

@@ -14,13 +14,13 @@ parameter count: 1

bytecode array length: 18

bytecodes: [

/* 30 E> */ B(StackCheck),

- /* 42 S> */ B(LdaSmi), U8(1),

+ /* 42 S> */ B(LdaSmi), I8(1),

B(Star), R(0),

/* 45 S> */ B(JumpIfToBooleanTrue), U8(8),

B(LdaZero),

/* 56 E> */ B(TestLessThan), R(0), U8(2),

B(JumpIfFalse), U8(5),

- /* 63 S> */ B(LdaSmi), U8(1),

+ /* 63 S> */ B(LdaSmi), I8(1),

/* 75 S> */ B(Return),

B(LdaUndefined),

/* 75 S> */ B(Return),

@@ -39,13 +39,13 @@ parameter count: 1

bytecode array length: 18

bytecodes: [

/* 30 E> */ B(StackCheck),

- /* 42 S> */ B(LdaSmi), U8(1),

+ /* 42 S> */ B(LdaSmi), I8(1),

B(Star), R(0),

/* 45 S> */ B(JumpIfToBooleanFalse), U8(11),

B(LdaZero),

/* 56 E> */ B(TestLessThan), R(0), U8(2),

B(JumpIfFalse), U8(5),

- /* 63 S> */ B(LdaSmi), U8(1),

+ /* 63 S> */ B(LdaSmi), I8(1),

/* 75 S> */ B(Return),

B(LdaUndefined),

/* 75 S> */ B(Return),

@@ -64,15 +64,15 @@ parameter count: 1

bytecode array length: 23

bytecodes: [

/* 30 E> */ B(StackCheck),

- /* 42 S> */ B(LdaSmi), U8(1),

+ /* 42 S> */ B(LdaSmi), I8(1),

B(Star), R(0),

/* 45 S> */ B(JumpIfToBooleanTrue), U8(8),

B(LdaZero),

/* 57 E> */ B(TestLessThan), R(0), U8(2),

B(JumpIfFalse), U8(6),

- B(LdaSmi), U8(2),

+ B(LdaSmi), I8(2),

B(Jump), U8(4),

- B(LdaSmi), U8(3),

+ B(LdaSmi), I8(3),

B(Star), R(0),

B(LdaUndefined),

/* 71 S> */ B(Return),