test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden - Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden

Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden ('k') | test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden b/test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden

index 422fa12cb1a3aa6512beebbd1c5f2a054bbb446e..4e0330ede3da5b0c297f94fb1d8ed8045a4fd78a 100644

--- a/test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden

+++ b/test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden

@@ -17,7 +17,7 @@ parameter count: 1

bytecode array length: 8

bytecodes: [

/* 21 E> */ B(StackCheck),

- /* 26 S> */ B(LdaSmi), U8(2),

+ /* 26 S> */ B(LdaSmi), I8(2),

/* 28 E> */ B(StaGlobalSloppy), U8(0), U8(2),

B(LdaUndefined),

/* 33 S> */ B(Return),

@@ -60,7 +60,7 @@ parameter count: 1

bytecode array length: 8

bytecodes: [

/* 35 E> */ B(StackCheck),

- /* 40 S> */ B(LdaSmi), U8(2),

+ /* 40 S> */ B(LdaSmi), I8(2),

/* 42 E> */ B(StaGlobalStrict), U8(0), U8(2),

B(LdaUndefined),

/* 47 S> */ B(Return),

@@ -82,7 +82,7 @@ parameter count: 1

bytecode array length: 8

bytecodes: [

/* 17 E> */ B(StackCheck),

- /* 22 S> */ B(LdaSmi), U8(2),

+ /* 22 S> */ B(LdaSmi), I8(2),

/* 24 E> */ B(StaGlobalSloppy), U8(0), U8(2),

B(LdaUndefined),

/* 29 S> */ B(Return),

@@ -490,7 +490,7 @@ bytecodes: [

/* 1286 E> */ B(LdaNamedProperty), R(arg0), U8(0), U8(254),

/* 1295 S> */ B(Nop),

/* 1296 E> */ B(Wide), B(LdaNamedProperty), R16(arg0), U16(0), U16(256),

- /* 1305 S> */ B(LdaSmi), U8(2),

+ /* 1305 S> */ B(LdaSmi), I8(2),

/* 1307 E> */ B(Wide), B(StaGlobalSloppy), U16(1), U16(258),

B(LdaUndefined),

/* 1312 S> */ B(Return),

@@ -900,7 +900,7 @@ bytecodes: [

/* 1302 E> */ B(LdaNamedProperty), R(arg0), U8(0), U8(254),

/* 1311 S> */ B(Nop),

/* 1312 E> */ B(Wide), B(LdaNamedProperty), R16(arg0), U16(0), U16(256),

- /* 1321 S> */ B(LdaSmi), U8(2),

+ /* 1321 S> */ B(LdaSmi), I8(2),

/* 1323 E> */ B(Wide), B(StaGlobalStrict), U16(1), U16(258),

B(LdaUndefined),

/* 1328 S> */ B(Return),