Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

Issue 2640273002: [ignition] Expect 'I' for signed bytecode operands (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
index 10b054e6fd98567c1c4f9657dba29f5d39a0000a..3bb478f3c40a444c2d23628c85cd27d1cac9757f 100644
--- a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
+++ b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
@@ -68,27 +68,27 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
- /* 53 S> */ B(LdaSmi), U8(1),
+ /* 53 S> */ B(LdaSmi), I8(1),
B(Star), R(1),
- /* 65 S> */ B(LdaSmi), U8(10),
+ /* 65 S> */ B(LdaSmi), I8(10),
/* 65 E> */ B(TestLessThan), R(0), U8(2),
B(JumpIfFalse), U8(38),
/* 56 E> */ B(StackCheck),
- /* 75 S> */ B(LdaSmi), U8(12),
+ /* 75 S> */ B(LdaSmi), I8(12),
/* 81 E> */ B(Mul), R(1), U8(3),
B(Star), R(1),
- /* 89 S> */ B(LdaSmi), U8(1),
+ /* 89 S> */ B(LdaSmi), I8(1),
/* 95 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
- /* 102 S> */ B(LdaSmi), U8(3),
+ /* 102 S> */ B(LdaSmi), I8(3),
/* 108 E> */ B(TestEqual), R(0), U8(5),
B(JumpIfFalse), U8(4),
/* 114 S> */ B(Jump), U8(11),
- /* 126 S> */ B(LdaSmi), U8(4),
+ /* 126 S> */ B(LdaSmi), I8(4),
/* 132 E> */ B(TestEqual), R(0), U8(6),
B(JumpIfFalse), U8(4),
/* 138 S> */ B(Jump), U8(5),
- B(JumpLoop), U8(40), U8(0),
+ B(JumpLoop), U8(40), I8(0),
/* 147 S> */ B(Ldar), R(1),
/* 157 S> */ B(Return),
]
@@ -122,26 +122,26 @@ bytecodes: [
/* 68 E> */ B(TestLessThan), R(0), U8(2),
B(JumpIfFalse), U8(4),
/* 73 S> */ B(Jump), U8(45),
- /* 85 S> */ B(LdaSmi), U8(3),
+ /* 85 S> */ B(LdaSmi), I8(3),
/* 91 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 97 S> */ B(Jump), U8(39),
- /* 106 S> */ B(LdaSmi), U8(4),
+ /* 106 S> */ B(LdaSmi), I8(4),
/* 112 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 118 S> */ B(Jump), U8(30),
- /* 127 S> */ B(LdaSmi), U8(10),
+ /* 127 S> */ B(LdaSmi), I8(10),
/* 133 E> */ B(TestEqual), R(0), U8(5),
B(JumpIfFalse), U8(4),
/* 140 S> */ B(Jump), U8(18),
- /* 152 S> */ B(LdaSmi), U8(5),
+ /* 152 S> */ B(LdaSmi), I8(5),
/* 158 E> */ B(TestEqual), R(0), U8(6),
B(JumpIfFalse), U8(4),
/* 164 S> */ B(Jump), U8(12),
- /* 173 S> */ B(LdaSmi), U8(1),
+ /* 173 S> */ B(LdaSmi), I8(1),
/* 179 E> */ B(Add), R(0), U8(7),
B(Star), R(0),
- B(JumpLoop), U8(52), U8(0),
+ B(JumpLoop), U8(52), I8(0),
/* 186 S> */ B(Ldar), R(0),
/* 196 S> */ B(Return),
]
@@ -171,19 +171,19 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
- /* 71 S> */ B(LdaSmi), U8(3),
+ /* 71 S> */ B(LdaSmi), I8(3),
/* 71 E> */ B(TestLessThan), R(0), U8(2),
B(JumpIfFalse), U8(22),
/* 62 E> */ B(StackCheck),
- /* 82 S> */ B(LdaSmi), U8(2),
+ /* 82 S> */ B(LdaSmi), I8(2),
/* 88 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 94 S> */ B(Jump), U8(12),
- /* 105 S> */ B(LdaSmi), U8(1),
+ /* 105 S> */ B(LdaSmi), I8(1),
/* 111 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
- B(JumpLoop), U8(24), U8(1),
- /* 122 S> */ B(LdaSmi), U8(1),
+ B(JumpLoop), U8(24), I8(1),
+ /* 122 S> */ B(LdaSmi), I8(1),
/* 128 E> */ B(Add), R(0), U8(5),
B(Star), R(0),
/* 135 S> */ B(Jump), U8(2),
@@ -210,20 +210,20 @@ parameter count: 1
bytecode array length: 34
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 42 S> */ B(LdaSmi), U8(10),
+ /* 42 S> */ B(LdaSmi), I8(10),
B(Star), R(0),
- /* 54 S> */ B(LdaSmi), U8(1),
+ /* 54 S> */ B(LdaSmi), I8(1),
B(Star), R(1),
/* 64 S> */ B(Ldar), R(0),
B(JumpIfToBooleanFalse), U8(20),
/* 57 E> */ B(StackCheck),
- /* 71 S> */ B(LdaSmi), U8(12),
+ /* 71 S> */ B(LdaSmi), I8(12),
/* 77 E> */ B(Mul), R(1), U8(2),
B(Star), R(1),
- /* 85 S> */ B(LdaSmi), U8(1),
+ /* 85 S> */ B(LdaSmi), I8(1),
/* 91 E> */ B(Sub), R(0), U8(3),
B(Star), R(0),
- B(JumpLoop), U8(19), U8(0),
+ B(JumpLoop), U8(19), I8(0),
/* 98 S> */ B(Ldar), R(1),
/* 108 S> */ B(Return),
]
@@ -250,27 +250,27 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
- /* 53 S> */ B(LdaSmi), U8(1),
+ /* 53 S> */ B(LdaSmi), I8(1),
B(Star), R(1),
/* 56 E> */ B(StackCheck),
- /* 63 S> */ B(LdaSmi), U8(10),
+ /* 63 S> */ B(LdaSmi), I8(10),
/* 69 E> */ B(Mul), R(1), U8(2),
B(Star), R(1),
- /* 77 S> */ B(LdaSmi), U8(5),
+ /* 77 S> */ B(LdaSmi), I8(5),
/* 83 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 89 S> */ B(Jump), U8(28),
- /* 98 S> */ B(LdaSmi), U8(6),
+ /* 98 S> */ B(LdaSmi), I8(6),
/* 104 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 110 S> */ B(Jump), U8(9),
- /* 122 S> */ B(LdaSmi), U8(1),
+ /* 122 S> */ B(LdaSmi), I8(1),
/* 128 E> */ B(Add), R(0), U8(5),
B(Star), R(0),
- /* 144 S> */ B(LdaSmi), U8(10),
+ /* 144 S> */ B(LdaSmi), I8(10),
/* 144 E> */ B(TestLessThan), R(0), U8(6),
B(JumpIfFalse), U8(5),
- B(JumpLoop), U8(40), U8(0),
+ B(JumpLoop), U8(40), I8(0),
/* 151 S> */ B(Ldar), R(1),
/* 161 S> */ B(Return),
]
@@ -294,19 +294,19 @@ parameter count: 1
bytecode array length: 32
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 42 S> */ B(LdaSmi), U8(10),
+ /* 42 S> */ B(LdaSmi), I8(10),
B(Star), R(0),
- /* 54 S> */ B(LdaSmi), U8(1),
+ /* 54 S> */ B(LdaSmi), I8(1),
B(Star), R(1),
/* 57 E> */ B(StackCheck),
- /* 64 S> */ B(LdaSmi), U8(12),
+ /* 64 S> */ B(LdaSmi), I8(12),
/* 70 E> */ B(Mul), R(1), U8(2),
B(Star), R(1),
- /* 78 S> */ B(LdaSmi), U8(1),
+ /* 78 S> */ B(LdaSmi), I8(1),
/* 84 E> */ B(Sub), R(0), U8(3),
B(Star), R(0),
/* 98 S> */ B(JumpIfToBooleanFalse), U8(5),
- B(JumpLoop), U8(17), U8(0),
+ B(JumpLoop), U8(17), I8(0),
/* 102 S> */ B(Ldar), R(1),
/* 112 S> */ B(Return),
]
@@ -333,20 +333,20 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
- /* 53 S> */ B(LdaSmi), U8(1),
+ /* 53 S> */ B(LdaSmi), I8(1),
B(Star), R(1),
/* 56 E> */ B(StackCheck),
- /* 63 S> */ B(LdaSmi), U8(10),
+ /* 63 S> */ B(LdaSmi), I8(10),
/* 69 E> */ B(Mul), R(1), U8(2),
B(Star), R(1),
- /* 77 S> */ B(LdaSmi), U8(5),
+ /* 77 S> */ B(LdaSmi), I8(5),
/* 83 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 89 S> */ B(Jump), U8(18),
- /* 98 S> */ B(LdaSmi), U8(1),
+ /* 98 S> */ B(LdaSmi), I8(1),
/* 104 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
- /* 111 S> */ B(LdaSmi), U8(6),
+ /* 111 S> */ B(LdaSmi), I8(6),
/* 117 E> */ B(TestEqual), R(0), U8(5),
B(JumpIfFalse), U8(4),
/* 123 S> */ B(Jump), U8(2),
@@ -376,24 +376,24 @@ bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
- /* 53 S> */ B(LdaSmi), U8(1),
+ /* 53 S> */ B(LdaSmi), I8(1),
B(Star), R(1),
/* 56 E> */ B(StackCheck),
- /* 63 S> */ B(LdaSmi), U8(10),
+ /* 63 S> */ B(LdaSmi), I8(10),
/* 69 E> */ B(Mul), R(1), U8(2),
B(Star), R(1),
- /* 77 S> */ B(LdaSmi), U8(5),
+ /* 77 S> */ B(LdaSmi), I8(5),
/* 83 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 89 S> */ B(Jump), U8(21),
- /* 98 S> */ B(LdaSmi), U8(1),
+ /* 98 S> */ B(LdaSmi), I8(1),
/* 104 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
- /* 111 S> */ B(LdaSmi), U8(6),
+ /* 111 S> */ B(LdaSmi), I8(6),
/* 117 E> */ B(TestEqual), R(0), U8(5),
B(JumpIfFalse), U8(4),
/* 123 S> */ B(Jump), U8(2),
- B(JumpLoop), U8(33), U8(0),
+ B(JumpLoop), U8(33), I8(0),
/* 149 S> */ B(Ldar), R(1),
/* 159 S> */ B(Return),
]
@@ -419,18 +419,18 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
- /* 58 S> */ B(LdaSmi), U8(1),
+ /* 58 S> */ B(LdaSmi), I8(1),
/* 64 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
/* 70 S> */ B(Jump), U8(21),
- /* 79 S> */ B(LdaSmi), U8(2),
+ /* 79 S> */ B(LdaSmi), I8(2),
/* 85 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 91 S> */ B(Jump), U8(9),
- /* 103 S> */ B(LdaSmi), U8(1),
+ /* 103 S> */ B(LdaSmi), I8(1),
/* 109 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
- B(JumpLoop), U8(26), U8(0),
+ B(JumpLoop), U8(26), I8(0),
B(LdaUndefined),
/* 116 S> */ B(Return),
]
@@ -455,18 +455,18 @@ bytecodes: [
/* 47 S> */ B(LdaZero),
B(Star), R(0),
/* 34 E> */ B(StackCheck),
- /* 56 S> */ B(LdaSmi), U8(1),
+ /* 56 S> */ B(LdaSmi), I8(1),
/* 62 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
/* 68 S> */ B(Jump), U8(21),
- /* 77 S> */ B(LdaSmi), U8(2),
+ /* 77 S> */ B(LdaSmi), I8(2),
/* 83 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 89 S> */ B(Jump), U8(9),
- /* 101 S> */ B(LdaSmi), U8(1),
+ /* 101 S> */ B(LdaSmi), I8(1),
/* 107 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
- B(JumpLoop), U8(26), U8(0),
+ B(JumpLoop), U8(26), I8(0),
B(LdaUndefined),
/* 114 S> */ B(Return),
]
@@ -491,18 +491,18 @@ bytecodes: [
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
- /* 68 S> */ B(LdaSmi), U8(1),
+ /* 68 S> */ B(LdaSmi), I8(1),
/* 74 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 80 S> */ B(Jump), U8(21),
- /* 89 S> */ B(LdaSmi), U8(2),
+ /* 89 S> */ B(LdaSmi), I8(2),
/* 95 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 101 S> */ B(Jump), U8(2),
- /* 55 S> */ B(LdaSmi), U8(1),
+ /* 55 S> */ B(LdaSmi), I8(1),
/* 59 E> */ B(Add), R(0), U8(2),
B(Star), R(0),
- B(JumpLoop), U8(26), U8(0),
+ B(JumpLoop), U8(26), I8(0),
B(LdaUndefined),
/* 113 S> */ B(Return),
]
@@ -526,18 +526,18 @@ bytecodes: [
/* 47 S> */ B(LdaZero),
B(Star), R(0),
/* 34 E> */ B(StackCheck),
- /* 66 S> */ B(LdaSmi), U8(1),
+ /* 66 S> */ B(LdaSmi), I8(1),
/* 72 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 78 S> */ B(Jump), U8(21),
- /* 87 S> */ B(LdaSmi), U8(2),
+ /* 87 S> */ B(LdaSmi), I8(2),
/* 93 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 99 S> */ B(Jump), U8(2),
- /* 53 S> */ B(LdaSmi), U8(1),
+ /* 53 S> */ B(LdaSmi), I8(1),
/* 57 E> */ B(Add), R(0), U8(2),
B(Star), R(0),
- B(JumpLoop), U8(26), U8(0),
+ B(JumpLoop), U8(26), I8(0),
B(LdaUndefined),
/* 111 S> */ B(Return),
]
@@ -563,18 +563,18 @@ bytecodes: [
B(Star), R(0),
/* 58 S> */ B(LdaZero),
B(Star), R(1),
- /* 63 S> */ B(LdaSmi), U8(100),
+ /* 63 S> */ B(LdaSmi), I8(100),
/* 63 E> */ B(TestLessThan), R(1), U8(2),
B(JumpIfFalse), U8(22),
/* 45 E> */ B(StackCheck),
- /* 85 S> */ B(LdaSmi), U8(1),
+ /* 85 S> */ B(LdaSmi), I8(1),
/* 91 E> */ B(Add), R(0), U8(4),
B(Star), R(0),
/* 98 S> */ B(Jump), U8(2),
- /* 72 S> */ B(LdaSmi), U8(1),
+ /* 72 S> */ B(LdaSmi), I8(1),
/* 76 E> */ B(Add), R(1), U8(3),
B(Star), R(1),
- B(JumpLoop), U8(24), U8(0),
+ B(JumpLoop), U8(24), I8(0),
B(LdaUndefined),
/* 110 S> */ B(Return),
]
@@ -596,20 +596,20 @@ parameter count: 1
bytecode array length: 33
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 42 S> */ B(LdaSmi), U8(1),
+ /* 42 S> */ B(LdaSmi), I8(1),
B(Star), R(0),
- /* 58 S> */ B(LdaSmi), U8(10),
+ /* 58 S> */ B(LdaSmi), I8(10),
B(Star), R(1),
/* 62 S> */ B(Ldar), R(1),
B(JumpIfToBooleanFalse), U8(19),
/* 45 E> */ B(StackCheck),
- /* 74 S> */ B(LdaSmi), U8(12),
+ /* 74 S> */ B(LdaSmi), I8(12),
/* 80 E> */ B(Mul), R(0), U8(3),
B(Star), R(0),
/* 67 S> */ B(Ldar), R(1),
B(Dec), U8(2),
B(Star), R(1),
- B(JumpLoop), U8(18), U8(0),
+ B(JumpLoop), U8(18), I8(0),
/* 88 S> */ B(Ldar), R(0),
/* 98 S> */ B(Return),
]
@@ -662,17 +662,17 @@ bytecodes: [
/* 58 S> */ B(LdaZero),
B(Star), R(1),
/* 45 E> */ B(StackCheck),
- /* 76 S> */ B(LdaSmi), U8(1),
+ /* 76 S> */ B(LdaSmi), I8(1),
/* 82 E> */ B(Add), R(0), U8(3),
B(Star), R(0),
- /* 89 S> */ B(LdaSmi), U8(20),
+ /* 89 S> */ B(LdaSmi), I8(20),
/* 95 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 102 S> */ B(Jump), U8(11),
/* 69 S> */ B(Ldar), R(1),
B(Inc), U8(2),
B(Star), R(1),
- B(JumpLoop), U8(23), U8(0),
+ B(JumpLoop), U8(23), I8(0),
/* 112 S> */ B(Ldar), R(0),
/* 122 S> */ B(Return),
]
@@ -710,7 +710,7 @@ bytecodes: [
B(StaCurrentContextSlot), U8(4),
B(CreateClosure), U8(1), U8(2), U8(2),
B(Star), R(0),
- /* 73 S> */ B(LdaSmi), U8(1),
+ /* 73 S> */ B(LdaSmi), I8(1),
/* 73 E> */ B(StaCurrentContextSlot), U8(4),
B(Mov), R(0), R(2),
/* 106 S> */ B(LdaCurrentContextSlot), U8(4),
@@ -722,7 +722,7 @@ bytecodes: [
B(Inc), U8(3),
/* 127 E> */ B(StaCurrentContextSlot), U8(4),
B(PopContext), R(3),
- B(JumpLoop), U8(45), U8(0),
+ B(JumpLoop), U8(45), I8(0),
B(LdaUndefined),
/* 137 S> */ B(Return),
]
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698