Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2639533002: [generators] Always call function with closure context when resuming. (Closed)

Created:
3 years, 11 months ago by neis
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Always call function with closure context when resuming. The resume trampolin used to call the generator function with the context of the last suspension rather than the closure's context. While that was fine for Ignition, Turbofan got utterly confused. With this CL, the resume trampolin always passes in the closure's context (like in the very first call of the generator function). The generator function itself then restores its previously current context by reading it from the generator object and doing a PushContext. BUG=chromium:681171 Review-Url: https://codereview.chromium.org/2639533002 Cr-Commit-Position: refs/heads/master@{#42407} Committed: https://chromium.googlesource.com/v8/v8/+/c5948b9897fd3d2fe2cb670375eda59ff7aff0c9

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cleanup tests. #

Patch Set 3 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -552 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 14 chunks +241 lines, -235 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 16 chunks +327 lines, -305 lines 0 comments Download
A test/mjsunit/regress/regress-681171-1.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-681171-2.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-681171-3.js View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
neis
PTAL (other ports to be done)
3 years, 11 months ago (2017-01-17 12:02:06 UTC) #4
Jarin
lgtm https://codereview.chromium.org/2639533002/diff/1/test/mjsunit/regress/regress-681171-1.js File test/mjsunit/regress/regress-681171-1.js (right): https://codereview.chromium.org/2639533002/diff/1/test/mjsunit/regress/regress-681171-1.js#newcode15 test/mjsunit/regress/regress-681171-1.js:15: "xxx".match(); Please, use some sensible formatting (here and ...
3 years, 11 months ago (2017-01-17 12:13:14 UTC) #5
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-17 12:18:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639533002/40001
3 years, 11 months ago (2017-01-17 13:42:15 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 13:44:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/c5948b9897fd3d2fe2cb670375eda59ff7a...

Powered by Google App Engine
This is Rietveld 408576698