Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/builtins/ia32/builtins-ia32.cc

Issue 2639533002: [generators] Always call function with closure context when resuming. (Closed)
Patch Set: Ports. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/arm64/builtins-arm64.cc ('k') | src/builtins/mips/builtins-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 379
380 // Store input value into generator object. 380 // Store input value into generator object.
381 __ mov(FieldOperand(ebx, JSGeneratorObject::kInputOrDebugPosOffset), eax); 381 __ mov(FieldOperand(ebx, JSGeneratorObject::kInputOrDebugPosOffset), eax);
382 __ RecordWriteField(ebx, JSGeneratorObject::kInputOrDebugPosOffset, eax, ecx, 382 __ RecordWriteField(ebx, JSGeneratorObject::kInputOrDebugPosOffset, eax, ecx,
383 kDontSaveFPRegs); 383 kDontSaveFPRegs);
384 384
385 // Store resume mode into generator object. 385 // Store resume mode into generator object.
386 __ mov(FieldOperand(ebx, JSGeneratorObject::kResumeModeOffset), edx); 386 __ mov(FieldOperand(ebx, JSGeneratorObject::kResumeModeOffset), edx);
387 387
388 // Load suspended function and context. 388 // Load suspended function and context.
389 __ mov(esi, FieldOperand(ebx, JSGeneratorObject::kContextOffset));
390 __ mov(edi, FieldOperand(ebx, JSGeneratorObject::kFunctionOffset)); 389 __ mov(edi, FieldOperand(ebx, JSGeneratorObject::kFunctionOffset));
390 __ mov(esi, FieldOperand(edi, JSFunction::kContextOffset));
391 391
392 // Flood function if we are stepping. 392 // Flood function if we are stepping.
393 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator; 393 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator;
394 Label stepping_prepared; 394 Label stepping_prepared;
395 ExternalReference debug_hook = 395 ExternalReference debug_hook =
396 ExternalReference::debug_hook_on_function_call_address(masm->isolate()); 396 ExternalReference::debug_hook_on_function_call_address(masm->isolate());
397 __ cmpb(Operand::StaticVariable(debug_hook), Immediate(0)); 397 __ cmpb(Operand::StaticVariable(debug_hook), Immediate(0));
398 __ j(not_equal, &prepare_step_in_if_stepping); 398 __ j(not_equal, &prepare_step_in_if_stepping);
399 399
400 // Flood function if we need to continue stepping in the suspended generator. 400 // Flood function if we need to continue stepping in the suspended generator.
(...skipping 2698 matching lines...) Expand 10 before | Expand all | Expand 10 after
3099 3099
3100 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) { 3100 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) {
3101 Generate_OnStackReplacementHelper(masm, true); 3101 Generate_OnStackReplacementHelper(masm, true);
3102 } 3102 }
3103 3103
3104 #undef __ 3104 #undef __
3105 } // namespace internal 3105 } // namespace internal
3106 } // namespace v8 3106 } // namespace v8
3107 3107
3108 #endif // V8_TARGET_ARCH_IA32 3108 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/builtins/arm64/builtins-arm64.cc ('k') | src/builtins/mips/builtins-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698