Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/builtins/arm64/builtins-arm64.cc

Issue 2639533002: [generators] Always call function with closure context when resuming. (Closed)
Patch Set: Ports. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/ia32/builtins-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/deoptimizer.h" 10 #include "src/deoptimizer.h"
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 737
738 // Store input value into generator object. 738 // Store input value into generator object.
739 __ Str(x0, FieldMemOperand(x1, JSGeneratorObject::kInputOrDebugPosOffset)); 739 __ Str(x0, FieldMemOperand(x1, JSGeneratorObject::kInputOrDebugPosOffset));
740 __ RecordWriteField(x1, JSGeneratorObject::kInputOrDebugPosOffset, x0, x3, 740 __ RecordWriteField(x1, JSGeneratorObject::kInputOrDebugPosOffset, x0, x3,
741 kLRHasNotBeenSaved, kDontSaveFPRegs); 741 kLRHasNotBeenSaved, kDontSaveFPRegs);
742 742
743 // Store resume mode into generator object. 743 // Store resume mode into generator object.
744 __ Str(x2, FieldMemOperand(x1, JSGeneratorObject::kResumeModeOffset)); 744 __ Str(x2, FieldMemOperand(x1, JSGeneratorObject::kResumeModeOffset));
745 745
746 // Load suspended function and context. 746 // Load suspended function and context.
747 __ Ldr(cp, FieldMemOperand(x1, JSGeneratorObject::kContextOffset));
748 __ Ldr(x4, FieldMemOperand(x1, JSGeneratorObject::kFunctionOffset)); 747 __ Ldr(x4, FieldMemOperand(x1, JSGeneratorObject::kFunctionOffset));
748 __ Ldr(cp, FieldMemOperand(x4, JSFunction::kContextOffset));
749 749
750 // Flood function if we are stepping. 750 // Flood function if we are stepping.
751 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator; 751 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator;
752 Label stepping_prepared; 752 Label stepping_prepared;
753 ExternalReference debug_hook = 753 ExternalReference debug_hook =
754 ExternalReference::debug_hook_on_function_call_address(masm->isolate()); 754 ExternalReference::debug_hook_on_function_call_address(masm->isolate());
755 __ Mov(x10, Operand(debug_hook)); 755 __ Mov(x10, Operand(debug_hook));
756 __ Ldrsb(x10, MemOperand(x10)); 756 __ Ldrsb(x10, MemOperand(x10));
757 __ CompareAndBranch(x10, Operand(0), ne, &prepare_step_in_if_stepping); 757 __ CompareAndBranch(x10, Operand(0), ne, &prepare_step_in_if_stepping);
758 758
(...skipping 2232 matching lines...) Expand 10 before | Expand all | Expand 10 after
2991 __ Unreachable(); 2991 __ Unreachable();
2992 } 2992 }
2993 } 2993 }
2994 2994
2995 #undef __ 2995 #undef __
2996 2996
2997 } // namespace internal 2997 } // namespace internal
2998 } // namespace v8 2998 } // namespace v8
2999 2999
3000 #endif // V8_TARGET_ARCH_ARM 3000 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/builtins/arm/builtins-arm.cc ('k') | src/builtins/ia32/builtins-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698