Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: src/builtins/x87/builtins-x87.cc

Issue 2639533002: [generators] Always call function with closure context when resuming. (Closed)
Patch Set: Ports. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/x64/builtins-x64.cc ('k') | src/compiler/js-intrinsic-lowering.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 380
381 // Store input value into generator object. 381 // Store input value into generator object.
382 __ mov(FieldOperand(ebx, JSGeneratorObject::kInputOrDebugPosOffset), eax); 382 __ mov(FieldOperand(ebx, JSGeneratorObject::kInputOrDebugPosOffset), eax);
383 __ RecordWriteField(ebx, JSGeneratorObject::kInputOrDebugPosOffset, eax, ecx, 383 __ RecordWriteField(ebx, JSGeneratorObject::kInputOrDebugPosOffset, eax, ecx,
384 kDontSaveFPRegs); 384 kDontSaveFPRegs);
385 385
386 // Store resume mode into generator object. 386 // Store resume mode into generator object.
387 __ mov(FieldOperand(ebx, JSGeneratorObject::kResumeModeOffset), edx); 387 __ mov(FieldOperand(ebx, JSGeneratorObject::kResumeModeOffset), edx);
388 388
389 // Load suspended function and context. 389 // Load suspended function and context.
390 __ mov(esi, FieldOperand(ebx, JSGeneratorObject::kContextOffset));
391 __ mov(edi, FieldOperand(ebx, JSGeneratorObject::kFunctionOffset)); 390 __ mov(edi, FieldOperand(ebx, JSGeneratorObject::kFunctionOffset));
391 __ mov(esi, FieldOperand(edi, JSFunction::kContextOffset));
392 392
393 // Flood function if we are stepping. 393 // Flood function if we are stepping.
394 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator; 394 Label prepare_step_in_if_stepping, prepare_step_in_suspended_generator;
395 Label stepping_prepared; 395 Label stepping_prepared;
396 ExternalReference debug_hook = 396 ExternalReference debug_hook =
397 ExternalReference::debug_hook_on_function_call_address(masm->isolate()); 397 ExternalReference::debug_hook_on_function_call_address(masm->isolate());
398 __ cmpb(Operand::StaticVariable(debug_hook), Immediate(0)); 398 __ cmpb(Operand::StaticVariable(debug_hook), Immediate(0));
399 __ j(not_equal, &prepare_step_in_if_stepping); 399 __ j(not_equal, &prepare_step_in_if_stepping);
400 400
401 // Flood function if we need to continue stepping in the suspended generator. 401 // Flood function if we need to continue stepping in the suspended generator.
(...skipping 2725 matching lines...) Expand 10 before | Expand all | Expand 10 after
3127 3127
3128 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) { 3128 void Builtins::Generate_InterpreterOnStackReplacement(MacroAssembler* masm) {
3129 Generate_OnStackReplacementHelper(masm, true); 3129 Generate_OnStackReplacementHelper(masm, true);
3130 } 3130 }
3131 3131
3132 #undef __ 3132 #undef __
3133 } // namespace internal 3133 } // namespace internal
3134 } // namespace v8 3134 } // namespace v8
3135 3135
3136 #endif // V8_TARGET_ARCH_X87 3136 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/builtins/x64/builtins-x64.cc ('k') | src/compiler/js-intrinsic-lowering.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698