gpu: Add ARB_occlusion_query support.

gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves overdraw
tracing by using this extension to collect exact amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2639293002
Cr-Commit-Position: refs/heads/master@{#445151}
Committed: https://chromium.googlesource.com/chromium/src/+/e2f29f0eda0cb38f57db34c7343ef4e6cce40263

[reveman, 2017-01-18 15:15:33]

Description was changed from

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves
overdraw tracing by using this extension to collect exact
amount of overdraw.

BUG=678234
==========

to

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves
overdraw tracing by using this extension to collect exact
amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[reveman, 2017-01-18 15:15:33]

Description was changed from

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves
overdraw tracing by using this extension to collect exact
amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves
overdraw tracing by using this extension to collect exact
amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[reveman, 2017-01-18 18:34:44]

Description was changed from

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves
overdraw tracing by using this extension to collect exact
amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves overdraw
tracing by using this extension to collect exact amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[reveman, 2017-01-18 18:49:47]

reveman@chromium.org changed reviewers:
+ danakj@chromium.org, jbauman@chromium.org

[reveman, 2017-01-18 18:49:48]

+jbauman for gpu/ and ui/
+danakj for cc/

[danakj, 2017-01-18 19:34:07]

https://codereview.chromium.org/2639293002/diff/40001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2639293002/diff/40001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:3616: current_surface_size_.GetArea());
I don't think you can/should use a member variable like this here. You should
pass the size in when the query is bound or you have a race if it changes.

[reveman, 2017-01-18 20:05:28]

https://codereview.chromium.org/2639293002/diff/40001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2639293002/diff/40001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:3616: current_surface_size_.GetArea());
On 2017/01/18 at 19:34:06, danakj (slow) wrote:
> I don't think you can/should use a member variable like this here. You should
pass the size in when the query is bound or you have a race if it changes.

Done.

[jbauman, 2017-01-19 01:33:43]

Could you add a simple test to query_manager_unittest.cc?

https://codereview.chromium.org/2639293002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2639293002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1183: feature_flags_.occlusion_query
= have_arb_occlusion_query;
I think this was promoted to core in OpenGL 1.5 (desktop), so you should check
for that as well.

[reveman, 2017-01-19 04:44:34]

On 2017/01/19 at 01:33:43, jbauman wrote:
> Could you add a simple test to query_manager_unittest.cc?

Done.

https://codereview.chromium.org/2639293002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2639293002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1183: feature_flags_.occlusion_query
= have_arb_occlusion_query;
On 2017/01/19 at 01:33:43, jbauman wrote:
> I think this was promoted to core in OpenGL 1.5 (desktop), so you should check
for that as well.

Good call. Added it to the have_arb_occlusion_query check in latest patch.

[reveman, 2017-01-19 04:44:44]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 04:45:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 06:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 06:25:31]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-01-20 19:02:06]

lgtm

[danakj, 2017-01-20 19:13:28]

cc LGTM

[reveman, 2017-01-20 19:21:12]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:21:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 19:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:30:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[reveman, 2017-01-20 19:32:21]

reveman@chromium.org changed reviewers:
+ dcheng@chromium.org

[reveman, 2017-01-20 19:32:21]

+dcheng for gpu/ipc/common/gpu_command_buffer_traits_multi.h

[reveman, 2017-01-20 19:36:18]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 19:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-01-20 19:59:48]

lgtm

[reveman, 2017-01-20 20:00:26]

The CQ bit was unchecked by reveman@chromium.org

[reveman, 2017-01-20 20:00:28]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2017-01-20 20:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 20:40:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484942428499660,
"parent_rev": "840012cf9996d156f6e3286a37ca0c9d5d502edc", "commit_rev":
"e2f29f0eda0cb38f57db34c7343ef4e6cce40263"}

[commit-bot: I haz the power, 2017-01-20 20:41:08]

Description was changed from

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves overdraw
tracing by using this extension to collect exact amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
gpu: Add ARB_occlusion_query support.

This adds support for GL_ARB_occlusion_query and improves overdraw
tracing by using this extension to collect exact amount of overdraw.

BUG=678234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2639293002
Cr-Commit-Position: refs/heads/master@{#445151}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2f29f0eda0cb38f57db34c7343e...
==========

[commit-bot: I haz the power, 2017-01-20 20:41:09]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e2f29f0eda0cb38f57db34c7343e...