Set layer element id when building layers in PaintArtifactCompositor.

Set layer element id when building layers in PaintArtifactCompositor.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2637383006
Cr-Commit-Position: refs/heads/master@{#445260}
Committed: https://chromium.googlesource.com/chromium/src/+/4243922107810fd1644fafa33cd8329ed1616515

[wkorman, 2017-01-20 00:53:23]

Description was changed from

==========
Set layer element id when building layers in PaintArtifactCompositor.

BUG=674317
==========

to

==========
Set layer element id when building layers in PaintArtifactCompositor.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-01-20 00:56:37]

wkorman@chromium.org changed reviewers:
+ ajuma@chromium.org, pdr@chromium.org

[wkorman, 2017-01-20 00:56:38]

Note dependent patchset. Will write unit test after initial comment.

https://codereview.chromium.org/2637383006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
(right):

https://codereview.chromium.org/2637383006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h:74: const
CompositorElementId compositorElementId() const;
We could put this logic in PaintArtifactCompositor as a static method but seemed
cleaner this way, open to thoughts though.

[ajuma, 2017-01-20 15:07:46]

https://codereview.chromium.org/2637383006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
(right):

https://codereview.chromium.org/2637383006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp:35: //
the same on all that have a non-default CompositorElementId.
Is it worth DCHECK-ing that this holds?

[wkorman, 2017-01-20 22:13:56]

PTAL, added tests.

https://codereview.chromium.org/2637383006/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
(right):

https://codereview.chromium.org/2637383006/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp:35: //
the same on all that have a non-default CompositorElementId.
On 2017/01/20 at 15:07:46, ajuma wrote:
> Is it worth DCHECK-ing that this holds?

Done.

[ajuma, 2017-01-20 23:25:45]

Thanks, lgtm

[pdr., 2017-01-21 01:32:46]

On 2017/01/20 at 23:25:45, ajuma wrote:
> Thanks, lgtm

LGTM

[wkorman, 2017-01-21 01:36:12]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2017-01-21 01:36:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org,
pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2637383006/#ps60001
(title: "Sync to head.")

[commit-bot: I haz the power, 2017-01-21 01:36:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 03:15:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484962572552640,
"parent_rev": "adbf15668dc1beadf9ee73fe1d7784a5aba207c3", "commit_rev":
"4243922107810fd1644fafa33cd8329ed1616515"}

[commit-bot: I haz the power, 2017-01-21 03:17:09]

Description was changed from

==========
Set layer element id when building layers in PaintArtifactCompositor.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Set layer element id when building layers in PaintArtifactCompositor.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2637383006
Cr-Commit-Position: refs/heads/master@{#445260}
Committed:
https://chromium.googlesource.com/chromium/src/+/4243922107810fd1644fafa33cd8...
==========

[commit-bot: I haz the power, 2017-01-21 03:17:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4243922107810fd1644fafa33cd8...