third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp - Issue 2637383006: Set layer element id when building layers in PaintArtifactCompositor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2637383006: Set layer element id when building layers in PaintArtifactCompositor. (Closed)

Patch Set: Sync to head. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

index c58bcde33d42102ce96836d6dd5809f1da515d7d..d0985d34611205069f8c8a1dee45ec55a3f52c7c 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

@@ -686,6 +686,7 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, OneScrollNode) {

EXPECT_EQ(expectedCompositorElementId, scrollNode.element_id);

EXPECT_EQ(scrollNode.id,

elementIdToScrollNodeIndex(expectedCompositorElementId));

+ EXPECT_EQ(expectedCompositorElementId, contentLayerAt(0)->element_id());

const cc::TransformTree& transformTree = propertyTrees().transform_tree;

const cc::TransformNode& transformNode =

@@ -751,6 +752,8 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {

EXPECT_EQ(expectedCompositorElementIdB, scrollNodeB.element_id);

EXPECT_EQ(scrollNodeB.id,

elementIdToScrollNodeIndex(expectedCompositorElementIdB));

+ EXPECT_EQ(expectedCompositorElementIdA, contentLayerAt(0)->element_id());

+ EXPECT_EQ(expectedCompositorElementIdB, contentLayerAt(1)->element_id());

const cc::TransformTree& transformTree = propertyTrees().transform_tree;

const cc::TransformNode& transformNodeA =