Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 263643005: Move ExtensionService::ReportExtensionLoadError to ExtensionErrorReporter (Closed)

Created:
6 years, 7 months ago by Devlin
Modified:
6 years, 7 months ago
Reviewers:
Finnur, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionService::ReportExtensionLoadError to ExtensionErrorReporter This isn't a huge improvement, because ExtensionErrorReporter has its own faults, but it at least centers all the logic in the same module, and handles a 2.5 year TODO from aa. This will (hopefully) make it easier when we continue to refactor this logic. BUG=351891 TBR=finnur@chromium.org (for one line change to web_ui) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -22 lines) Patch
M chrome/browser/extensions/extension_error_reporter.h View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_error_reporter.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_loader_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
6 years, 7 months ago (2014-04-30 16:52:19 UTC) #1
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-04-30 17:21:13 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-01 15:51:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/263643005/1
6 years, 7 months ago (2014-05-01 15:51:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 15:59:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-05-01 15:59:44 UTC) #6
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 7 months ago (2014-05-01 16:38:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/263643005/1
6 years, 7 months ago (2014-05-01 16:39:15 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 17:26:14 UTC) #9
Message was sent while issue was closed.
Change committed as 267562

Powered by Google App Engine
This is Rietveld 408576698