Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: chrome/browser/extensions/installed_loader.cc

Issue 263643005: Move ExtensionService::ReportExtensionLoadError to ExtensionErrorReporter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/unpacked_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/installed_loader.cc
diff --git a/chrome/browser/extensions/installed_loader.cc b/chrome/browser/extensions/installed_loader.cc
index ba3cdfd87dbceb2c84dadd29bec5b35cac8a740f..5470083162d4047e6c08175135cd948292f1b101 100644
--- a/chrome/browser/extensions/installed_loader.cc
+++ b/chrome/browser/extensions/installed_loader.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/api/runtime/runtime_api.h"
#include "chrome/browser/extensions/extension_action_manager.h"
+#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/common/chrome_switches.h"
@@ -171,7 +172,11 @@ void InstalledLoader::Load(const ExtensionInfo& info, bool write_to_prefs) {
}
if (!extension.get()) {
- extension_service_->ReportExtensionLoadError(info.extension_path, error);
+ ExtensionErrorReporter::GetInstance()->ReportLoadError(
+ info.extension_path,
+ error,
+ extension_service_->profile(),
+ false); // Be quiet.
return;
}
@@ -222,8 +227,11 @@ void InstalledLoader::LoadAllExtensions() {
&error));
if (!extension.get()) {
- extension_service_->ReportExtensionLoadError(
- info->extension_path, error);
+ ExtensionErrorReporter::GetInstance()->ReportLoadError(
+ info->extension_path,
+ error,
+ extension_service_->profile(),
+ false); // Be quiet.
continue;
}
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/unpacked_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698