Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 263643005: Move ExtensionService::ReportExtensionLoadError to ExtensionErrorReporter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/unpacked_installer.cc
diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc
index 867c183b49e87872f8567ad848ee85534bf9cdc6..56d5197e4d692ce3943fabfbfe4712519c132f04 100644
--- a/chrome/browser/extensions/unpacked_installer.cc
+++ b/chrome/browser/extensions/unpacked_installer.cc
@@ -11,6 +11,7 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread_restrictions.h"
+#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "chrome/browser/extensions/extension_install_ui.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -112,6 +113,7 @@ UnpackedInstaller::UnpackedInstaller(ExtensionService* extension_service)
: service_weak_(extension_service->AsWeakPtr()),
prompt_for_plugins_(true),
require_modern_manifest_version_(true),
+ be_noisy_on_failure_(true),
installer_(extension_service->profile()) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
}
@@ -296,8 +298,13 @@ void UnpackedInstaller::ReportExtensionLoadError(const std::string &error) {
if (!on_failure_callback_.is_null())
on_failure_callback_.Run(extension_path_, error);
- if (service_weak_.get())
- service_weak_->ReportExtensionLoadError(extension_path_, error);
+ if (service_weak_.get()) {
+ ExtensionErrorReporter::GetInstance()->ReportLoadError(
+ extension_path_,
+ error,
+ service_weak_->profile(),
+ be_noisy_on_failure_);
+ }
}
void UnpackedInstaller::ConfirmInstall() {
« no previous file with comments | « chrome/browser/extensions/unpacked_installer.h ('k') | chrome/browser/ui/webui/extensions/extension_loader_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698