Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: chrome/browser/extensions/extension_error_reporter.h

Issue 263643005: Move ExtensionService::ReportExtensionLoadError to ExtensionErrorReporter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_error_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_error_reporter.h
diff --git a/chrome/browser/extensions/extension_error_reporter.h b/chrome/browser/extensions/extension_error_reporter.h
index f5e2d10f98e9e12b4dcd85487e65e58aa770bd2d..ccc188754651c540defdefd89cac9986fda148f4 100644
--- a/chrome/browser/extensions/extension_error_reporter.h
+++ b/chrome/browser/extensions/extension_error_reporter.h
@@ -12,8 +12,11 @@
namespace base {
class MessageLoop;
+class FilePath;
}
+class Profile;
+
// Exposes an easy way for the various components of the extension system to
// report errors. This is a singleton that lives on the UI thread, with the
// exception of ReportError() which may be called from any thread.
@@ -31,6 +34,16 @@ class ExtensionErrorReporter {
// Get the singleton instance.
static ExtensionErrorReporter* GetInstance();
+ // Report an extension load error. This forwards to ReportError() after
+ // sending an EXTENSION_LOAD_ERROR notification.
+ // TODO(rdevlin.cronin): There's a lot wrong with this. But some of our
+ // systems rely on the notification. Investigate what it will take to remove
+ // the notification and this method.
+ void ReportLoadError(const base::FilePath& extension_path,
+ const std::string& error,
+ Profile* profile,
+ bool be_noisy);
+
// Report an error. Errors always go to VLOG(1). Optionally, they can also
// cause a noisy alert box.
void ReportError(const base::string16& message, bool be_noisy);
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_error_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698