Move ExtensionService::ReportExtensionLoadError to ExtensionErrorReporter

chrome/browser/extensions/installed_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/installed_loader.h"
 
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/runtime/runtime_api.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
+#include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/api/managed_mode_private/managed_mode_handler.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
@@ skipping 138 matching lines @@
                policy->MustRemainDisabled(extension, &disable_reason, NULL)) {
       extension_prefs_->SetExtensionState(extension->id(), Extension::DISABLED);
       extension_prefs_->AddDisableReason(extension->id(), disable_reason);
       force_disabled = true;
     }
     UMA_HISTOGRAM_BOOLEAN("ExtensionInstalledLoader.ForceDisabled",
                           force_disabled);
   }
 
   if (!extension.get()) {
-    extension_service_->ReportExtensionLoadError(info.extension_path, error);
+    ExtensionErrorReporter::GetInstance()->ReportLoadError(
+        info.extension_path,
+        error,
+        extension_service_->profile(),
+        false);  // Be quiet.
     return;
   }
 
   if (write_to_prefs)
     extension_prefs_->UpdateManifest(extension.get());
 
   extension_service_->AddExtension(extension.get());
 }
 
 void InstalledLoader::LoadAllExtensions() {
@@ skipping 30 matching lines @@
       base::ThreadRestrictions::ScopedAllowIO allow_io;
 
       std::string error;
       scoped_refptr<const Extension> extension(
           file_util::LoadExtension(info->extension_path,
                                    info->extension_location,
                                    GetCreationFlags(info),
                                    &error));
 
       if (!extension.get()) {
-        extension_service_->ReportExtensionLoadError(
-            info->extension_path, error);
+        ExtensionErrorReporter::GetInstance()->ReportLoadError(
+            info->extension_path,
+            error,
+            extension_service_->profile(),
+            false);  // Be quiet.
         continue;
       }
 
       extensions_info->at(i)->extension_manifest.reset(
           static_cast<base::DictionaryValue*>(
               extension->manifest()->value()->DeepCopy()));
       should_write_prefs = true;
     }
   }
 
@@ skipping 239 matching lines @@
 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {
   int flags = extension_prefs_->GetCreationFlags(info->extension_id);
   if (!Manifest::IsUnpackedLocation(info->extension_location))
     flags |= Extension::REQUIRE_KEY;
   if (extension_prefs_->AllowFileAccess(info->extension_id))
     flags |= Extension::ALLOW_FILE_ACCESS;
   return flags;
 }
 
 }  // namespace extensions