Clean up RenderWidgetHostView(ChildFrame and Guest) compositing code

Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

This CL achieves two goals:

- Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame to minimize code
duplication.

- Switches to cc::SurfaceInfo in IPC communications to simplify the
API and be consistent with Mojo which already uses SurfaceInfo.

TBR=sunnyps@chromium.org

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2633303003
Cr-Commit-Position: refs/heads/master@{#445585}
Committed: https://chromium.googlesource.com/chromium/src/+/56cee024237174f6a5a6281fa534bc3874aee8ef

[Saman Sami, 2017-01-17 20:45:27]

Description was changed from

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

BUG=668890
==========

to

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-01-17 20:47:00]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 20:47:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-17 20:50:33]

Description was changed from

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-01-17 20:50:33]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-01-17 20:54:12]

This is pretty awesome so far. Please make sure to sort method implementations.

https://codereview.chromium.org/2633303003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/2633303003/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_widget_host_view_guest.cc:290: void
RenderWidgetHostViewGuest::SendSurfaceInfoToChild(
I'd rather this actually take in a SurfaceInfo instead of reading member
variables.

[Saman Sami, 2017-01-17 21:25:49]

Description was changed from

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame which is used in
OnSwapCompositorFrame methods to minimize code duplication.

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-01-17 21:29:02]

On 2017/01/17 20:54:12, Fady Samuel wrote:
> This is pretty awesome so far. Please make sure to sort method
implementations.
> 
>
https://codereview.chromium.org/2633303003/diff/1/content/browser/frame_host/...
> File content/browser/frame_host/render_widget_host_view_guest.cc (right):
> 
>
https://codereview.chromium.org/2633303003/diff/1/content/browser/frame_host/...
> content/browser/frame_host/render_widget_host_view_guest.cc:290: void
> RenderWidgetHostViewGuest::SendSurfaceInfoToChild(
> I'd rather this actually take in a SurfaceInfo instead of reading member
> variables.

I was trying to be careful with the order, but the methods are already way out
of order.

[commit-bot: I haz the power, 2017-01-17 22:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 22:14:50]

Dry run: This issue passed the CQ dry run.

[Saman Sami, 2017-01-17 22:44:13]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 22:44:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-17 22:53:19]

Description was changed from

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame which is used in
OnSwapCompositorFrame methods to minimize code duplication.

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

This CL achieves two goals:

- Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame to minimize code
duplication.

- Switches to cc::SurfaceInfo in IPC communications to simplify the
API and be consistent with Mojo which already uses SurfaceInfo.

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-01-17 23:15:43]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 23:16:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:48:30]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-01-18 01:03:43]

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_child_frame.cc (right):

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_child_frame.cc:376: bool
RenderWidgetHostViewChildFrame::ShouldRecreateSurface(
I think ShouldCreateNewSurfaceId better captures what it's doing.

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_child_frame.cc:420: void
RenderWidgetHostViewChildFrame::SendSurfaceInfoToChild() {
This should be called SendSurfaceInfoToEmbedder

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_child_frame.cc:433: void
RenderWidgetHostViewChildFrame::SendSurfaceInfoToChild(
SendSurfaceInfoToEmbedder

[Saman Sami, 2017-01-18 18:15:41]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-01-18 18:15:53]

PTAL

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
File content/browser/frame_host/render_widget_host_view_child_frame.cc (right):

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_child_frame.cc:376: bool
RenderWidgetHostViewChildFrame::ShouldRecreateSurface(
On 2017/01/18 01:03:43, Fady Samuel wrote:
> I think ShouldCreateNewSurfaceId better captures what it's doing.

Done.

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_child_frame.cc:420: void
RenderWidgetHostViewChildFrame::SendSurfaceInfoToChild() {
On 2017/01/18 01:03:43, Fady Samuel wrote:
> This should be called SendSurfaceInfoToEmbedder

Done.

https://codereview.chromium.org/2633303003/diff/40001/content/browser/frame_h...
content/browser/frame_host/render_widget_host_view_child_frame.cc:433: void
RenderWidgetHostViewChildFrame::SendSurfaceInfoToChild(
On 2017/01/18 01:03:43, Fady Samuel wrote:
> SendSurfaceInfoToEmbedder

Done.

[commit-bot: I haz the power, 2017-01-18 18:16:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-01-18 18:17:48]

samans@chromium.org changed reviewers:
+ jam@chromium.org, tsepez@chromium.org

[Saman Sami, 2017-01-18 18:20:59]

jam@: Please review content/
tsepez@: Please review IPC (content/common and cc/)

[Fady Samuel, 2017-01-18 18:21:32]

lgtm

[Tom Sepez, 2017-01-18 18:39:03]

lgtm

[commit-bot: I haz the power, 2017-01-18 19:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:52:32]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-20 15:51:23]

On 2017/01/18 18:20:59, Saman Sami wrote:
> jam@: Please review content/
> tsepez@: Please review IPC (content/common and cc/)

I'm not really qualified to review these files.

[Fady Samuel, 2017-01-20 16:21:08]

fsamuel@chromium.org changed reviewers:
+ kenrb@chromium.org

[Fady Samuel, 2017-01-20 16:21:08]

+kenrb@ for content/ changes.

[Saman Sami, 2017-01-23 20:21:32]

samans@chromium.org changed reviewers:
+ nasko@chromium.org
- jam@chromium.org, kenrb@chromium.org

[Saman Sami, 2017-01-23 20:22:05]

nasko: Please review content/.

[kenrb, 2017-01-23 20:46:12]

kenrb@chromium.org changed reviewers:
+ kenrb@chromium.org

[kenrb, 2017-01-23 20:46:13]

I'm not an owner, but lgtm from my side. We hope to be getting rid of
RenderWidgetHostViewGuest in not too long, but this is a good cleanup.

[nasko, 2017-01-23 22:46:35]

Rubberstamp LGTM based on kenrb@'s review.

[Saman Sami, 2017-01-23 22:49:59]

samans@chromium.org changed reviewers:
+ sunnyps@chromium.org

[Saman Sami, 2017-01-23 22:50:30]

Description was changed from

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

This CL achieves two goals:

- Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame to minimize code
duplication.

- Switches to cc::SurfaceInfo in IPC communications to simplify the
API and be consistent with Mojo which already uses SurfaceInfo.

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

This CL achieves two goals:

- Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame to minimize code
duplication.

- Switches to cc::SurfaceInfo in IPC communications to simplify the
API and be consistent with Mojo which already uses SurfaceInfo.

TBR=sunnyps@chromium.org

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-01-23 22:50:42]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-01-23 22:51:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 01:45:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485211842042640,
"parent_rev": "7b20d2e9e9113b3ad2ee1db858e8d16d2b947058", "commit_rev":
"56cee024237174f6a5a6281fa534bc3874aee8ef"}

[commit-bot: I haz the power, 2017-01-24 01:45:42]

Description was changed from

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

This CL achieves two goals:

- Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame to minimize code
duplication.

- Switches to cc::SurfaceInfo in IPC communications to simplify the
API and be consistent with Mojo which already uses SurfaceInfo.

TBR=sunnyps@chromium.org

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Unify RenderWidgetHostView(ChildFrame and Guest) compositing code

This CL achieves two goals:

- Right now the code in OnSwapCompositorFrame methods in
RenderWidgetHostViewChildFrame and RenderWidgetHostViewGuest are almost
identical. This CL extracts the common parts of these two methods into
a new method called ProcessCompositorFrame to minimize code
duplication.

- Switches to cc::SurfaceInfo in IPC communications to simplify the
API and be consistent with Mojo which already uses SurfaceInfo.

TBR=sunnyps@chromium.org

BUG=668890
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2633303003
Cr-Commit-Position: refs/heads/master@{#445585}
Committed:
https://chromium.googlesource.com/chromium/src/+/56cee024237174f6a5a6281fa534...
==========

[commit-bot: I haz the power, 2017-01-24 01:45:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/56cee024237174f6a5a6281fa534...