Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2633303003: Clean up RenderWidgetHostView(ChildFrame and Guest) compositing code (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
11 #include <deque> 11 #include <deque>
12 #include <memory> 12 #include <memory>
13 #include <vector> 13 #include <vector>
14 14
15 #include "base/callback.h" 15 #include "base/callback.h"
16 #include "base/macros.h" 16 #include "base/macros.h"
17 #include "build/build_config.h" 17 #include "build/build_config.h"
18 #include "cc/resources/returned_resource.h" 18 #include "cc/resources/returned_resource.h"
19 #include "cc/scheduler/begin_frame_source.h" 19 #include "cc/scheduler/begin_frame_source.h"
20 #include "cc/surfaces/surface_factory_client.h" 20 #include "cc/surfaces/surface_factory_client.h"
21 #include "cc/surfaces/surface_id_allocator.h" 21 #include "cc/surfaces/surface_id_allocator.h"
22 #include "cc/surfaces/surface_info.h"
23 #include "cc/surfaces/surface_sequence.h"
22 #include "content/browser/compositor/image_transport_factory.h" 24 #include "content/browser/compositor/image_transport_factory.h"
23 #include "content/browser/renderer_host/event_with_latency_info.h" 25 #include "content/browser/renderer_host/event_with_latency_info.h"
24 #include "content/browser/renderer_host/render_widget_host_view_base.h" 26 #include "content/browser/renderer_host/render_widget_host_view_base.h"
25 #include "content/common/content_export.h" 27 #include "content/common/content_export.h"
26 #include "content/common/input/input_event_ack_state.h" 28 #include "content/common/input/input_event_ack_state.h"
27 #include "content/public/browser/readback_types.h" 29 #include "content/public/browser/readback_types.h"
28 #include "ui/gfx/geometry/rect.h" 30 #include "ui/gfx/geometry/rect.h"
29 #include "ui/gfx/native_widget_types.h" 31 #include "ui/gfx/native_widget_types.h"
30 32
31 namespace cc { 33 namespace cc {
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 void UpdateViewportIntersection(const gfx::Rect& viewport_intersection); 199 void UpdateViewportIntersection(const gfx::Rect& viewport_intersection);
198 200
199 protected: 201 protected:
200 friend class RenderWidgetHostView; 202 friend class RenderWidgetHostView;
201 friend class RenderWidgetHostViewChildFrameTest; 203 friend class RenderWidgetHostViewChildFrameTest;
202 friend class RenderWidgetHostViewGuestSurfaceTest; 204 friend class RenderWidgetHostViewGuestSurfaceTest;
203 205
204 explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget); 206 explicit RenderWidgetHostViewChildFrame(RenderWidgetHost* widget);
205 void Init(); 207 void Init();
206 208
209 virtual bool ShouldCreateNewSurfaceId(uint32_t compositor_frame_sink_id,
210 const cc::CompositorFrame& frame);
211
212 void ProcessCompositorFrame(uint32_t compositor_frame_sink_id,
213 cc::CompositorFrame frame);
214
215 void SendSurfaceInfoToEmbedder();
216
207 // Clears current compositor surface, if one is in use. 217 // Clears current compositor surface, if one is in use.
208 void ClearCompositorSurfaceIfNecessary(); 218 void ClearCompositorSurfaceIfNecessary();
209 219
210 void ProcessFrameSwappedCallbacks(); 220 void ProcessFrameSwappedCallbacks();
211 221
212 // The last scroll offset of the view. 222 // The last scroll offset of the view.
213 gfx::Vector2dF last_scroll_offset_; 223 gfx::Vector2dF last_scroll_offset_;
214 224
215 // Members will become private when RenderWidgetHostViewGuest is removed. 225 // Members will become private when RenderWidgetHostViewGuest is removed.
216 // The model object. 226 // The model object.
(...skipping 16 matching lines...) Expand all
233 243
234 // frame_connector_ provides a platform abstraction. Messages 244 // frame_connector_ provides a platform abstraction. Messages
235 // sent through it are routed to the embedding renderer process. 245 // sent through it are routed to the embedding renderer process.
236 CrossProcessFrameConnector* frame_connector_; 246 CrossProcessFrameConnector* frame_connector_;
237 247
238 base::WeakPtr<RenderWidgetHostViewChildFrame> AsWeakPtr() { 248 base::WeakPtr<RenderWidgetHostViewChildFrame> AsWeakPtr() {
239 return weak_factory_.GetWeakPtr(); 249 return weak_factory_.GetWeakPtr();
240 } 250 }
241 251
242 private: 252 private:
253 virtual void SendSurfaceInfoToEmbedderImpl(
254 const cc::SurfaceInfo& surface_info,
255 const cc::SurfaceSequence& sequence);
256
243 void SubmitSurfaceCopyRequest(const gfx::Rect& src_subrect, 257 void SubmitSurfaceCopyRequest(const gfx::Rect& src_subrect,
244 const gfx::Size& dst_size, 258 const gfx::Size& dst_size,
245 const ReadbackRequestCallback& callback, 259 const ReadbackRequestCallback& callback,
246 const SkColorType preferred_color_type); 260 const SkColorType preferred_color_type);
247 261
248 using FrameSwappedCallbackList = std::deque<std::unique_ptr<base::Closure>>; 262 using FrameSwappedCallbackList = std::deque<std::unique_ptr<base::Closure>>;
249 // Since frame-drawn callbacks are "fire once", we use std::deque to make 263 // Since frame-drawn callbacks are "fire once", we use std::deque to make
250 // it convenient to swap() when processing the list. 264 // it convenient to swap() when processing the list.
251 FrameSwappedCallbackList frame_swapped_callbacks_; 265 FrameSwappedCallbackList frame_swapped_callbacks_;
252 266
253 // The begin frame source being observed. Null if none. 267 // The begin frame source being observed. Null if none.
254 cc::BeginFrameSource* begin_frame_source_; 268 cc::BeginFrameSource* begin_frame_source_;
255 cc::BeginFrameArgs last_begin_frame_args_; 269 cc::BeginFrameArgs last_begin_frame_args_;
256 // The surface client ID of the parent RenderWidgetHostView. 0 if none. 270 // The surface client ID of the parent RenderWidgetHostView. 0 if none.
257 cc::FrameSinkId parent_frame_sink_id_; 271 cc::FrameSinkId parent_frame_sink_id_;
258 272
259 base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_; 273 base::WeakPtrFactory<RenderWidgetHostViewChildFrame> weak_factory_;
260 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame); 274 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewChildFrame);
261 }; 275 };
262 276
263 } // namespace content 277 } // namespace content
264 278
265 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_ 279 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_CHILD_FRAME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698