Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2633303003: Clean up RenderWidgetHostView(ChildFrame and Guest) compositing code (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
index 7c45027a1c314bbbbc34bd742eb8ebe8f9b1c1f5..b7d6fe2c5b6ca2d4ee875d14de71d30193b2b830 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
@@ -51,26 +51,19 @@ class MockRenderWidgetHostDelegate : public RenderWidgetHostDelegate {
class MockCrossProcessFrameConnector : public CrossProcessFrameConnector {
public:
- MockCrossProcessFrameConnector()
- : CrossProcessFrameConnector(nullptr), last_scale_factor_received_(0.f) {}
+ MockCrossProcessFrameConnector() : CrossProcessFrameConnector(nullptr) {}
~MockCrossProcessFrameConnector() override {}
- void SetChildFrameSurface(const cc::SurfaceId& surface_id,
- const gfx::Size& frame_size,
- float scale_factor,
+ void SetChildFrameSurface(const cc::SurfaceInfo& surface_info,
const cc::SurfaceSequence& sequence) override {
- last_surface_id_received_ = surface_id;
- last_frame_size_received_ = frame_size;
- last_scale_factor_received_ = scale_factor;
+ last_surface_info_ = surface_info;
}
RenderWidgetHostViewBase* GetParentRenderWidgetHostView() override {
return nullptr;
}
- cc::SurfaceId last_surface_id_received_;
- gfx::Size last_frame_size_received_;
- float last_scale_factor_received_;
+ cc::SurfaceInfo last_surface_info_;
};
} // namespace
@@ -192,9 +185,8 @@ TEST_F(RenderWidgetHostViewChildFrameTest, SwapCompositorFrame) {
// Surface ID should have been passed to CrossProcessFrameConnector to
// be sent to the embedding renderer.
- EXPECT_EQ(id, test_frame_connector_->last_surface_id_received_);
- EXPECT_EQ(view_size, test_frame_connector_->last_frame_size_received_);
- EXPECT_EQ(scale_factor, test_frame_connector_->last_scale_factor_received_);
+ EXPECT_EQ(cc::SurfaceInfo(id, scale_factor, view_size),
+ test_frame_connector_->last_surface_info_);
}
}

Powered by Google App Engine
This is Rietveld 408576698