Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc

Issue 2633303003: Clean up RenderWidgetHostView(ChildFrame and Guest) compositing code (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" 5 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 ~MockRenderWidgetHostDelegate() override {} 44 ~MockRenderWidgetHostDelegate() override {}
45 private: 45 private:
46 void Cut() override {} 46 void Cut() override {}
47 void Copy() override {} 47 void Copy() override {}
48 void Paste() override {} 48 void Paste() override {}
49 void SelectAll() override {} 49 void SelectAll() override {}
50 }; 50 };
51 51
52 class MockCrossProcessFrameConnector : public CrossProcessFrameConnector { 52 class MockCrossProcessFrameConnector : public CrossProcessFrameConnector {
53 public: 53 public:
54 MockCrossProcessFrameConnector() 54 MockCrossProcessFrameConnector() : CrossProcessFrameConnector(nullptr) {}
55 : CrossProcessFrameConnector(nullptr), last_scale_factor_received_(0.f) {}
56 ~MockCrossProcessFrameConnector() override {} 55 ~MockCrossProcessFrameConnector() override {}
57 56
58 void SetChildFrameSurface(const cc::SurfaceId& surface_id, 57 void SetChildFrameSurface(const cc::SurfaceInfo& surface_info,
59 const gfx::Size& frame_size,
60 float scale_factor,
61 const cc::SurfaceSequence& sequence) override { 58 const cc::SurfaceSequence& sequence) override {
62 last_surface_id_received_ = surface_id; 59 last_surface_info_ = surface_info;
63 last_frame_size_received_ = frame_size;
64 last_scale_factor_received_ = scale_factor;
65 } 60 }
66 61
67 RenderWidgetHostViewBase* GetParentRenderWidgetHostView() override { 62 RenderWidgetHostViewBase* GetParentRenderWidgetHostView() override {
68 return nullptr; 63 return nullptr;
69 } 64 }
70 65
71 cc::SurfaceId last_surface_id_received_; 66 cc::SurfaceInfo last_surface_info_;
72 gfx::Size last_frame_size_received_;
73 float last_scale_factor_received_;
74 }; 67 };
75 68
76 } // namespace 69 } // namespace
77 70
78 class RenderWidgetHostViewChildFrameTest : public testing::Test { 71 class RenderWidgetHostViewChildFrameTest : public testing::Test {
79 public: 72 public:
80 RenderWidgetHostViewChildFrameTest() {} 73 RenderWidgetHostViewChildFrameTest() {}
81 74
82 void SetUp() override { 75 void SetUp() override {
83 browser_context_.reset(new TestBrowserContext); 76 browser_context_.reset(new TestBrowserContext);
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 cc::SurfaceManager* manager = 178 cc::SurfaceManager* manager =
186 factory->GetContextFactoryPrivate()->GetSurfaceManager(); 179 factory->GetContextFactoryPrivate()->GetSurfaceManager();
187 cc::Surface* surface = manager->GetSurfaceForId(id); 180 cc::Surface* surface = manager->GetSurfaceForId(id);
188 EXPECT_TRUE(surface); 181 EXPECT_TRUE(surface);
189 // There should be a SurfaceSequence created by the RWHVChildFrame. 182 // There should be a SurfaceSequence created by the RWHVChildFrame.
190 EXPECT_EQ(1u, surface->GetDestructionDependencyCount()); 183 EXPECT_EQ(1u, surface->GetDestructionDependencyCount());
191 #endif 184 #endif
192 185
193 // Surface ID should have been passed to CrossProcessFrameConnector to 186 // Surface ID should have been passed to CrossProcessFrameConnector to
194 // be sent to the embedding renderer. 187 // be sent to the embedding renderer.
195 EXPECT_EQ(id, test_frame_connector_->last_surface_id_received_); 188 EXPECT_EQ(cc::SurfaceInfo(id, scale_factor, view_size),
196 EXPECT_EQ(view_size, test_frame_connector_->last_frame_size_received_); 189 test_frame_connector_->last_surface_info_);
197 EXPECT_EQ(scale_factor, test_frame_connector_->last_scale_factor_received_);
198 } 190 }
199 } 191 }
200 192
201 } // namespace content 193 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698