Migrate tests to use EXPECT_DCHECK_DEATH instead of EXPECT_DEATH.

Migrate tests to use EXPECT_DCHECK_DEATH instead of EXPECT_DEATH.

EXPECT_DCHECK_DEATH() takes into account build configuration options
such as DCHECK_ALWAYS_ON, removing the need for each test site to wrap
EXPECT_DEATH() with preprocessor conditionals.

This is a pre-requisite to enable the dump-on-DCHECK experiment.

BUG=596231
Review-Url: https://codereview.chromium.org/2630963002
Cr-Commit-Position: refs/heads/master@{#444087}
Committed: https://chromium.googlesource.com/chromium/src/+/976ae7de15986e38271f1dfaf9edc10838de9e0f

[Wez, 2017-01-15 00:07:36]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 00:07:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2017-01-15 00:09:58]

wez@chromium.org changed reviewers:
+ jam@chromium.org

[Wez, 2017-01-15 00:09:59]

PTAL: These changes were pulled out of the dump-on-DCHECK implementation patch
(issue 2288473002). They're required in order for us to have a load of
DCHECK-specific death tests behave correctly when DCHECK is configured to
dump-without-crashing.

[commit-bot: I haz the power, 2017-01-15 01:32:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 01:32:27]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-17 16:45:26]

lgtm

[Wez, 2017-01-17 16:58:31]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-01-17 16:58:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 17:51:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484672311567150, "parent_rev":
"3fe3d39e93d6f7b4ba011074fc322fecb713d3f6", "commit_rev":
"976ae7de15986e38271f1dfaf9edc10838de9e0f"}

[commit-bot: I haz the power, 2017-01-17 17:51:38]

Description was changed from

==========
Migrate tests to use EXPECT_DCHECK_DEATH instead of EXPECT_DEATH.

EXPECT_DCHECK_DEATH() takes into account build configuration options
such as DCHECK_ALWAYS_ON, removing the need for each test site to wrap
EXPECT_DEATH() with preprocessor conditionals.

This is a pre-requisite to enable the dump-on-DCHECK experiment.

BUG=596231
==========

to

==========
Migrate tests to use EXPECT_DCHECK_DEATH instead of EXPECT_DEATH.

EXPECT_DCHECK_DEATH() takes into account build configuration options
such as DCHECK_ALWAYS_ON, removing the need for each test site to wrap
EXPECT_DEATH() with preprocessor conditionals.

This is a pre-requisite to enable the dump-on-DCHECK experiment.

BUG=596231

Review-Url: https://codereview.chromium.org/2630963002
Cr-Commit-Position: refs/heads/master@{#444087}
Committed:
https://chromium.googlesource.com/chromium/src/+/976ae7de15986e38271f1dfaf9ed...
==========

[commit-bot: I haz the power, 2017-01-17 17:51:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/976ae7de15986e38271f1dfaf9ed...