Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: chrome/test/chromedriver/net/timeout_unittest.cc

Issue 2630963002: Migrate tests to use EXPECT_DCHECK_DEATH instead of EXPECT_DEATH. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "base/test/gtest_util.h"
6 #include "chrome/test/chromedriver/net/timeout.h" 7 #include "chrome/test/chromedriver/net/timeout.h"
7 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
8 9
9 using base::TimeDelta; 10 using base::TimeDelta;
10 11
11 TEST(TimeoutTest, Basics) { 12 TEST(TimeoutTest, Basics) {
12 Timeout timeout; 13 Timeout timeout;
13 EXPECT_FALSE(timeout.is_set()); 14 EXPECT_FALSE(timeout.is_set());
14 EXPECT_FALSE(timeout.IsExpired()); 15 EXPECT_FALSE(timeout.IsExpired());
15 EXPECT_EQ(TimeDelta::Max(), timeout.GetDuration()); 16 EXPECT_EQ(TimeDelta::Max(), timeout.GetDuration());
16 EXPECT_EQ(TimeDelta::Max(), timeout.GetRemainingTime()); 17 EXPECT_EQ(TimeDelta::Max(), timeout.GetRemainingTime());
17 18
18 timeout.SetDuration(TimeDelta()); 19 timeout.SetDuration(TimeDelta());
19 EXPECT_TRUE(timeout.is_set()); 20 EXPECT_TRUE(timeout.is_set());
20 EXPECT_TRUE(timeout.IsExpired()); 21 EXPECT_TRUE(timeout.IsExpired());
21 EXPECT_EQ(TimeDelta(), timeout.GetDuration()); 22 EXPECT_EQ(TimeDelta(), timeout.GetDuration());
22 EXPECT_GE(TimeDelta(), timeout.GetRemainingTime()); 23 EXPECT_GE(TimeDelta(), timeout.GetRemainingTime());
23 } 24 }
24 25
25 TEST(TimeoutTest, SetDuration) { 26 TEST(TimeoutTest, SetDuration) {
26 Timeout timeout(TimeDelta::FromSeconds(1)); 27 Timeout timeout(TimeDelta::FromSeconds(1));
27 28
28 // It's ok to set the same duration again, since nothing changes. 29 // It's ok to set the same duration again, since nothing changes.
29 timeout.SetDuration(TimeDelta::FromSeconds(1)); 30 timeout.SetDuration(TimeDelta::FromSeconds(1));
30 31
31 #if DCHECK_IS_ON() && GTEST_HAS_DEATH_TEST && !defined(OS_ANDROID) 32 EXPECT_DCHECK_DEATH(timeout.SetDuration(TimeDelta::FromMinutes(30)));
32 EXPECT_DEATH(timeout.SetDuration(TimeDelta::FromMinutes(30)), "");
33 #endif // DCHECK_IS_ON() && GTEST_HAS_DEATH_TEST && !defined(OS_ANDROID)
34 } 33 }
35 34
36 TEST(TimeoutTest, Derive) { 35 TEST(TimeoutTest, Derive) {
37 Timeout timeout(TimeDelta::FromMinutes(5)); 36 Timeout timeout(TimeDelta::FromMinutes(5));
38 EXPECT_TRUE(timeout.is_set()); 37 EXPECT_TRUE(timeout.is_set());
39 EXPECT_FALSE(timeout.IsExpired()); 38 EXPECT_FALSE(timeout.IsExpired());
40 EXPECT_EQ(TimeDelta::FromMinutes(5), timeout.GetDuration()); 39 EXPECT_EQ(TimeDelta::FromMinutes(5), timeout.GetDuration());
41 EXPECT_GE(TimeDelta::FromMinutes(5), timeout.GetRemainingTime()); 40 EXPECT_GE(TimeDelta::FromMinutes(5), timeout.GetRemainingTime());
42 41
43 Timeout small = Timeout(TimeDelta::FromSeconds(10), &timeout); 42 Timeout small = Timeout(TimeDelta::FromSeconds(10), &timeout);
(...skipping 10 matching lines...) Expand all
54 TEST(TimeoutTest, DeriveExpired) { 53 TEST(TimeoutTest, DeriveExpired) {
55 Timeout timeout((TimeDelta())); 54 Timeout timeout((TimeDelta()));
56 EXPECT_TRUE(timeout.is_set()); 55 EXPECT_TRUE(timeout.is_set());
57 EXPECT_TRUE(timeout.IsExpired()); 56 EXPECT_TRUE(timeout.IsExpired());
58 57
59 Timeout derived = Timeout(TimeDelta::FromSeconds(10), &timeout); 58 Timeout derived = Timeout(TimeDelta::FromSeconds(10), &timeout);
60 EXPECT_TRUE(derived.is_set()); 59 EXPECT_TRUE(derived.is_set());
61 EXPECT_TRUE(derived.IsExpired()); 60 EXPECT_TRUE(derived.IsExpired());
62 EXPECT_GE(TimeDelta(), derived.GetDuration()); 61 EXPECT_GE(TimeDelta(), derived.GetDuration());
63 } 62 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/incognito_mode_prefs_unittest.cc ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698