Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6009)

Unified Diff: chrome/test/chromedriver/net/timeout_unittest.cc

Issue 2630963002: Migrate tests to use EXPECT_DCHECK_DEATH instead of EXPECT_DEATH. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/incognito_mode_prefs_unittest.cc ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/net/timeout_unittest.cc
diff --git a/chrome/test/chromedriver/net/timeout_unittest.cc b/chrome/test/chromedriver/net/timeout_unittest.cc
index eb3663152817018e5e0816598753b770e0704fa3..6626a07bb459f70c79b7af75e3daedd6e3b2cb0e 100644
--- a/chrome/test/chromedriver/net/timeout_unittest.cc
+++ b/chrome/test/chromedriver/net/timeout_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "base/logging.h"
+#include "base/test/gtest_util.h"
#include "chrome/test/chromedriver/net/timeout.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -28,9 +29,7 @@ TEST(TimeoutTest, SetDuration) {
// It's ok to set the same duration again, since nothing changes.
timeout.SetDuration(TimeDelta::FromSeconds(1));
-#if DCHECK_IS_ON() && GTEST_HAS_DEATH_TEST && !defined(OS_ANDROID)
- EXPECT_DEATH(timeout.SetDuration(TimeDelta::FromMinutes(30)), "");
-#endif // DCHECK_IS_ON() && GTEST_HAS_DEATH_TEST && !defined(OS_ANDROID)
+ EXPECT_DCHECK_DEATH(timeout.SetDuration(TimeDelta::FromMinutes(30)));
}
TEST(TimeoutTest, Derive) {
« no previous file with comments | « chrome/browser/prefs/incognito_mode_prefs_unittest.cc ('k') | mojo/public/cpp/bindings/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698