Add result to DumpWithoutCrashing, to indicate whether it did anything.

Add result to DumpWithoutCrashing, to indicate whether it did anything.

DumpWithoutCrashing() is ignored if SetDumpWithoutCrashingFunction()
has not yet been called. Since we want dump-on-DCHECK to dump on only
the first failed DCHECK, we need to ensure that failures prior to the
dump function being set are not counted.

This is a pre-requisite to enable the dump-on-DCHECK experiment.

BUG=596231
Review-Url: https://codereview.chromium.org/2638573002
Cr-Commit-Position: refs/heads/master@{#444173}
Committed: https://chromium.googlesource.com/chromium/src/+/b827921dd7839a813d33811c27478b966acac255

[Wez, 2017-01-15 00:23:26]

wez@chromium.org changed reviewers:
+ gab@chromium.org, zea@chromium.org

[Wez, 2017-01-15 00:23:27]

PTAL

[Wez, 2017-01-15 00:24:01]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 00:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-15 01:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 01:32:44]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2017-01-17 17:03:02]

sync lgtm

[gab, 2017-01-17 21:07:58]

lgtm

[Wez, 2017-01-17 21:40:33]

The CQ bit was checked by wez@chromium.org

[commit-bot: I haz the power, 2017-01-17 21:40:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 22:50:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484689233959690, "parent_rev":
"a571c3450ddb6b5305fb4cb245457ba2b8534e2e", "commit_rev":
"b827921dd7839a813d33811c27478b966acac255"}

[commit-bot: I haz the power, 2017-01-17 22:51:30]

Description was changed from

==========
Add result to DumpWithoutCrashing, to indicate whether it did anything.

DumpWithoutCrashing() is ignored if SetDumpWithoutCrashingFunction()
has not yet been called. Since we want dump-on-DCHECK to dump on only
the first failed DCHECK, we need to ensure that failures prior to the
dump function being set are not counted.

This is a pre-requisite to enable the dump-on-DCHECK experiment.

BUG=596231
==========

to

==========
Add result to DumpWithoutCrashing, to indicate whether it did anything.

DumpWithoutCrashing() is ignored if SetDumpWithoutCrashingFunction()
has not yet been called. Since we want dump-on-DCHECK to dump on only
the first failed DCHECK, we need to ensure that failures prior to the
dump function being set are not counted.

This is a pre-requisite to enable the dump-on-DCHECK experiment.

BUG=596231

Review-Url: https://codereview.chromium.org/2638573002
Cr-Commit-Position: refs/heads/master@{#444173}
Committed:
https://chromium.googlesource.com/chromium/src/+/b827921dd7839a813d33811c2747...
==========

[commit-bot: I haz the power, 2017-01-17 22:51:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b827921dd7839a813d33811c2747...