Remove |success| parameter from GeometryMapper's public methods

Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public methods and unit tests
to programmatically check for failures.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2630783002
Cr-Commit-Position: refs/heads/master@{#443659}
Committed: https://chromium.googlesource.com/chromium/src/+/bc1f9f18f5fc73921c06d29a54c48856493b7021

[Xianzhu, 2017-01-13 18:54:18]

Description was changed from

==========
Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public callers and unit tests
to programmatically check for failures.
==========

to

==========
Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public callers and unit tests
to programmatically check for failures.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-01-13 18:54:46]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2017-01-13 19:09:31]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-13 19:09:31]

lgtm

A nice cleanup.

[commit-bot: I haz the power, 2017-01-13 19:10:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-13 19:11:05]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-01-13 19:11:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2630783002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-13 19:11:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-01-13 19:12:11]

Description was changed from

==========
Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public callers and unit tests
to programmatically check for failures.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public methods and unit tests
to programmatically check for failures.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2017-01-13 20:48:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484334665978600,
"parent_rev": "6fb55614fe7830920d5048d7ba8289b4df1c8f1b", "commit_rev":
"bc1f9f18f5fc73921c06d29a54c48856493b7021"}

[commit-bot: I haz the power, 2017-01-13 20:49:30]

Description was changed from

==========
Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public methods and unit tests
to programmatically check for failures.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove |success| parameter from GeometryMapper's public methods

The callers always expect the methods to succeed, so the failures are
now checked in these methods with DCHECKs instead of returning |success|
to the callers.

Added private internal methods for the public methods and unit tests
to programmatically check for failures.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2630783002
Cr-Commit-Position: refs/heads/master@{#443659}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc1f9f18f5fc73921c06d29a54c4...
==========

[commit-bot: I haz the power, 2017-01-13 20:49:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bc1f9f18f5fc73921c06d29a54c4...