Reduce PropertyTreeState construction and copies

Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 6~8% of total
PrePaint time for paint-offset-changes.html. Try jobs showed that
this improved performance of the test by 1~8% on bots.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2621193006
Cr-Commit-Position: refs/heads/master@{#443632}
Committed: https://chromium.googlesource.com/chromium/src/+/fd01bedb5e520096733a05e9b92ee17d0ae8f848

[Xianzhu, 2017-01-13 03:33:40]

Description was changed from

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 10% of total
PrePaint time for paint-offset-changes.html.

BUG=678597
==========

to

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 10% of total
PrePaint time for paint-offset-changes.html.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-01-13 03:33:55]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 03:34:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:51:45]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-01-13 17:38:38]

Description was changed from

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 10% of total
PrePaint time for paint-offset-changes.html.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 6~8% of total
PrePaint time for paint-offset-changes.html.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-01-13 17:41:39]

Description was changed from

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 6~8% of total
PrePaint time for paint-offset-changes.html.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 6~8% of total
PrePaint time for paint-offset-changes.html. Try jobs showed that
this improved performance of the test by 1~8% on bots.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-01-13 17:41:55]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-01-13 18:57:13]

LGTM, this is a great idea. Good implementation too

[Xianzhu, 2017-01-13 18:59:13]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-01-13 18:59:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 19:06:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484333953189760, "parent_rev":
"3787fa693e2297fa5aae2891cc3a2087eb7e6833", "commit_rev":
"fd01bedb5e520096733a05e9b92ee17d0ae8f848"}

[commit-bot: I haz the power, 2017-01-13 19:07:30]

Description was changed from

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 6~8% of total
PrePaint time for paint-offset-changes.html. Try jobs showed that
this improved performance of the test by 1~8% on bots.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Reduce PropertyTreeState construction and copies

- Cache ObjectPaintProperties::contentsProperties() so that we don't
  create a new PropertyTreeState object on each call.
- Check necessity of GeometryMapper invocation before creating
  localTreeState.

This will avoid many PropertyTreeState constructions and RefPtr
constructions/destructions which contributed about 6~8% of total
PrePaint time for paint-offset-changes.html. Try jobs showed that
this improved performance of the test by 1~8% on bots.

BUG=678597
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2621193006
Cr-Commit-Position: refs/heads/master@{#443632}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd01bedb5e520096733a05e9b92e...
==========

[commit-bot: I haz the power, 2017-01-13 19:07:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fd01bedb5e520096733a05e9b92e...