third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2630783002: Remove |success| parameter from GeometryMapper's public methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2630783002: Remove |success| parameter from GeometryMapper's public methods (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index b66051133358b7eef5c5d95627e5bbc24c110338..8d146dbd29eed715e0b69f1f10c081b945c08aea 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -76,7 +76,6 @@ void PaintPropertyTreeBuilderTest::TearDown() {

GeometryMapper geometryMapper; \

LayoutRect source((sourceLayoutObject)->localVisualRect()); \

source.moveBy((sourceLayoutObject)->paintOffset()); \

- bool success = false; \

const auto& contentsProperties = \

*(ancestorLayoutObject)->paintProperties()->contentsProperties(); \

LayoutRect actual = \

@@ -84,8 +83,7 @@ void PaintPropertyTreeBuilderTest::TearDown() {

FloatRect(source), *(sourceLayoutObject) \

->paintProperties() \

->localBorderBoxProperties(), \

- contentsProperties, success)); \

- ASSERT_TRUE(success); \

+ contentsProperties)); \

actual.moveBy(-(ancestorLayoutObject)->paintOffset()); \

EXPECT_EQ(expected, actual) \

<< "GeometryMapper: expected: " << expected.toString() \