Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Issue 2630783002: Remove |success| parameter from GeometryMapper's public methods (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
index fb1f76d66f3b46d6feebf5214fac23659f535882..1aeca106f4747a34c6b96f6cab09c9375ebdb3b4 100644
--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
@@ -113,10 +113,8 @@ static LayoutRect mapLocalRectToPaintInvalidationBacking(
PropertyTreeState currentTreeState(
context.treeBuilderContext.current.transform,
context.treeBuilderContext.current.clip, nullptr, nullptr);
- bool success = false;
result = LayoutRect(geometryMapper.sourceToDestinationVisualRect(
- rect, currentTreeState, *containerContentsProperties, success));
- DCHECK(success);
+ rect, currentTreeState, *containerContentsProperties));
}
// Convert the result to the container's contents space.
@@ -176,14 +174,12 @@ LayoutPoint PaintInvalidator::computeLocationInBacking(
->contentsProperties()
->transform();
if (context.treeBuilderContext.current.transform != containerTransform) {
- bool success = false;
point = LayoutPoint(m_geometryMapper
.sourceToDestinationRect(
FloatRect(FloatPoint(point), FloatSize()),
context.treeBuilderContext.current.transform,
- containerTransform, success)
+ containerTransform)
.location());
- DCHECK(success);
}
// Convert the result to the container's contents space.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698