Move custom property isInheritedProperty storage logic into ComputedStyle

Move custom property isInheritedProperty storage logic into ComputedStyle

This change is a small refactor that pushes the details of whether
custom property values are stored in StyleInheritedVariables or
StyleNonInheritedVariables down into ComputedStyle. This is in preparation
for animations on registered custom properties and avoids duplicated
logic.

BUG=671904
Review-Url: https://codereview.chromium.org/2630683002
Cr-Commit-Position: refs/heads/master@{#443512}
Committed: https://chromium.googlesource.com/chromium/src/+/0ffd401266e9b6afb5e7595fcefd336765ffdc99

[alancutter (OOO until 2018), 2017-01-13 04:25:10]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-01-13 04:39:56]

On 2017/01/13 04:25:10, alancutter wrote:

lgtm

[alancutter (OOO until 2018), 2017-01-13 05:19:49]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-13 05:20:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 07:14:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484284789761770,
"parent_rev": "d5231cdb20da617c9625996b6e552c0f498d1889", "commit_rev":
"0ffd401266e9b6afb5e7595fcefd336765ffdc99"}

[commit-bot: I haz the power, 2017-01-13 07:15:27]

Description was changed from

==========
Move custom property isInheritedProperty storage logic into ComputedStyle

This change is a small refactor that pushes the details of whether
custom property values are stored in StyleInheritedVariables or
StyleNonInheritedVariables down into ComputedStyle. This is in preparation
for animations on registered custom properties and avoids duplicated
logic.

BUG=671904
==========

to

==========
Move custom property isInheritedProperty storage logic into ComputedStyle

This change is a small refactor that pushes the details of whether
custom property values are stored in StyleInheritedVariables or
StyleNonInheritedVariables down into ComputedStyle. This is in preparation
for animations on registered custom properties and avoids duplicated
logic.

BUG=671904

Review-Url: https://codereview.chromium.org/2630683002
Cr-Commit-Position: refs/heads/master@{#443512}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ffd401266e9b6afb5e7595fcefd...
==========

[commit-bot: I haz the power, 2017-01-13 07:15:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ffd401266e9b6afb5e7595fcefd...

[Timothy Loh, 2017-01-17 05:51:06]

Apparently I forgot to send out this message :o

https://codereview.chromium.org/2630683002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp (left):

https://codereview.chromium.org/2630683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp:931:
DCHECK(initial ^ inherit);
Can we just keep this? You loosened the check so now it wouldnt assert on
initial && inherit

[alancutter (OOO until 2018), 2017-01-17 06:08:15]

https://codereview.chromium.org/2630683002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp (left):

https://codereview.chromium.org/2630683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp:931:
DCHECK(initial ^ inherit);
On 2017/01/17 at 05:51:05, Timothy Loh wrote:
> Can we just keep this? You loosened the check so now it wouldnt assert on
initial && inherit

Ah, true. I mainly changed it so that the code below had DCHECK(inherit) as a
heading for readability.