Move custom property isInheritedProperty storage logic into ComputedStyle

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
  * All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
@@ skipping 910 matching lines @@
         state.style()->setResolvedNonInheritedVariable(
             name, declaration.value(), parsedValue);
       return;
     }
     if (isInheritedProperty)
       inherit = true;
     else
       initial = true;
   }
 
-  DCHECK(initial ^ inherit);

[Timothy Loh, 2017/01/17 05:51:05]

Can we just keep this? You loosened the check so now it wouldnt assert on
initial && inherit

[alancutter (OOO until 2018), 2017/01/17 06:08:15]

Ah, true. I mainly changed it so that the code below had DCHECK(inherit) as a
heading for readability.

-
+  state.style()->removeVariable(name, isInheritedProperty);
   if (initial) {
-    if (isInheritedProperty)
-      state.style()->removeInheritedVariable(name);
-    else
-      state.style()->removeNonInheritedVariable(name);
     return;
   }
 
-  if (isInheritedProperty) {
-    state.style()->removeInheritedVariable(name);
-    StyleInheritedVariables* parentVariables =
-        state.parentStyle()->inheritedVariables();
-    if (!parentVariables)
-      return;
-    CSSVariableData* parentValue = parentVariables->getVariable(name);
+  DCHECK(inherit);
+  CSSVariableData* parentValue =
+      state.parentStyle()->getVariable(name, isInheritedProperty);
+  const CSSValue* parentCSSValue =
+      registration && parentValue
+          ? state.parentStyle()->getRegisteredVariable(name,
+                                                       isInheritedProperty)
+          : nullptr;
+
+  if (!isInheritedProperty) {
+    DCHECK(registration);
     if (parentValue) {
-      if (!registration)
-        state.style()->setResolvedUnregisteredVariable(name, parentValue);
-      else
-        state.style()->setResolvedInheritedVariable(
-            name, parentValue, parentVariables->registeredVariable(name));
+      state.style()->setResolvedNonInheritedVariable(name, parentValue,
+                                                     parentCSSValue);
     }
     return;
   }
 
-  state.style()->removeNonInheritedVariable(name);
-  StyleNonInheritedVariables* parentVariables =
-      state.parentStyle()->nonInheritedVariables();
-  if (!parentVariables)
-    return;
-  CSSVariableData* parentValue = parentVariables->getVariable(name);
-  if (parentValue)
-    state.style()->setResolvedNonInheritedVariable(
-        name, parentValue, parentVariables->registeredVariable(name));
+  if (parentValue) {
+    if (!registration) {
+      state.style()->setResolvedUnregisteredVariable(name, parentValue);
+    } else {
+      state.style()->setResolvedInheritedVariable(name, parentValue,
+                                                  parentCSSValue);
+    }
+  }
 }
 
 void StyleBuilderFunctions::applyInheritCSSPropertyBaselineShift(
     StyleResolverState& state) {
   const SVGComputedStyle& parentSvgStyle = state.parentStyle()->svgStyle();
   EBaselineShift baselineShift = parentSvgStyle.baselineShift();
   SVGComputedStyle& svgStyle = state.style()->accessSVGStyle();
   svgStyle.setBaselineShift(baselineShift);
   if (baselineShift == BS_LENGTH)
     svgStyle.setBaselineShiftValue(parentSvgStyle.baselineShiftValue());
@@ skipping 56 matching lines @@
     state.style()->setCaretColor(
         StyleBuilderConverter::convertStyleAutoColor(state, value));
   }
   if (state.applyPropertyToVisitedLinkStyle()) {
     state.style()->setVisitedLinkCaretColor(
         StyleBuilderConverter::convertStyleAutoColor(state, value, true));
   }
 }
 
 }  // namespace blink