Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2631663002: Clean up ComputedStyleCSSValueMapping after change to ComputedStyle::getVariable() (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 11 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up ComputedStyleCSSValueMapping after change to ComputedStyle::getVariable() The change to ComputedStyle::getVariable() in https://codereview.chromium.org/2630683002 enables some logic in ComputedStyleCSSValueMapping to be removed. This patch is a minor tidy up of that logic. Review-Url: https://codereview.chromium.org/2631663002 Cr-Commit-Position: refs/heads/master@{#443825} Committed: https://chromium.googlesource.com/chromium/src/+/e4dc09ecc98ecda0724d906241c7c7cc6ef7a88a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +5 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-13 08:16:37 UTC) #2
Timothy Loh
On 2017/01/13 08:16:37, alancutter wrote: lgtm
3 years, 11 months ago (2017-01-15 22:49:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631663002/1
3 years, 11 months ago (2017-01-15 23:31:03 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 00:54:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4dc09ecc98ecda0724d906241c7...

Powered by Google App Engine
This is Rietveld 408576698