Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2630503002: Add code path for registered custom properties in CSSInterpolationType (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add code path for registered custom properties in CSSInterpolationType This change adds extra handling logic for registered custom properties in CSSInterpolationType that deals with their associated CSSValues instead of just the generic CSSCustomPropertyDeclaration values. This is in preparation for integration with the typed subclasses of CSSInterpolationType to produce values in between the specified animation keyframes. This patch is a refactor that has no change in behaviour. BUG=671904 Review-Url: https://codereview.chromium.org/2630503002 Cr-Commit-Position: refs/heads/master@{#444271} Committed: https://chromium.googlesource.com/chromium/src/+/271557f792311061db727bd05dcedd282c1c2272

Patch Set 1 #

Patch Set 2 : Moar buttons #

Messages

Total messages: 14 (9 generated)
alancutter (OOO until 2018)
+ericwilligers for InterpolationType changes. +timloh for custom property usage.
3 years, 11 months ago (2017-01-15 23:43:14 UTC) #7
Eric Willigers
lgtm
3 years, 11 months ago (2017-01-16 01:43:31 UTC) #8
Timothy Loh
On 2017/01/16 01:43:31, Eric Willigers wrote: > lgtm lgtm
3 years, 11 months ago (2017-01-18 02:24:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630503002/20001
3 years, 11 months ago (2017-01-18 02:26:55 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 04:22:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/271557f792311061db727bd05dce...

Powered by Google App Engine
This is Rietveld 408576698