Add smooth interpolation support for <color> custom properties

Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.

This does not add support for CSS Transitions, only CSS
Animations and Web Animations.
This does not add support for currentcolor for CSS Animations,
supporting this may require further redesigns to style resolution.

BUG=671904
Review-Url: https://codereview.chromium.org/2564793002
Cr-Original-Commit-Position: refs/heads/master@{#445967}
Committed: https://chromium.googlesource.com/chromium/src/+/96bee2c42c8df73523e971850215d29d1c40c15f
Review-Url: https://codereview.chromium.org/2564793002
Cr-Commit-Position: refs/heads/master@{#446919}
Committed: https://chromium.googlesource.com/chromium/src/+/b2f66c7a95b2d366e8972efc5acac53d60f4978d

[alancutter (OOO until 2018), 2016-12-14 06:25:38]

Description was changed from

==========
+registeredAnimation

BUG=
==========

to

==========
+registeredAnimation

BUG=671904
==========

[alancutter (OOO until 2018), 2017-01-13 09:51:30]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 09:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 12:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 12:56:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2017-01-16 00:15:48]

Description was changed from

==========
+registeredAnimation

BUG=671904
==========

to

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.
This does not include support for CSS Transitions, only CSS
Animations and Web Animations.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-01-16 00:15:48]

alancutter@chromium.org changed reviewers:
+ timloh@chromium.org

[alancutter (OOO until 2018), 2017-01-25 01:56:55]

alancutter@chromium.org changed reviewers:
+ sashab@chromium.org
- timloh@chromium.org

[alancutter (OOO until 2018), 2017-01-25 01:57:19]

On 2017/01/16 at 05:58:59, alancutter wrote:
> 

Switching reviewer to sashab. timloh no longer on Blink.

[sashab, 2017-01-25 02:55:00]

Some minor comments as discussed in person, other than that LGTM. Thanks for the
explanation. :^)

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/custom-properties/color-type-interpolation.html
(right):

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/color-type-interpolation.html:109:
]);
Add test for currentColor as well :^)

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js:102:
supportsProperty: function() {return true;},
These fixes are great, but maybe put in separate patch.

[alancutter (OOO until 2018), 2017-01-25 03:55:00]

Description was changed from

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.
This does not include support for CSS Transitions, only CSS
Animations and Web Animations.

BUG=671904
==========

to

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.

This does not add support for CSS Transitions, only CSS
Animations and Web Animations.
This does not add support for currentcolor for CSS Animations,
supporting this may require further redesigns to style resolution.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-01-25 03:55:14]

Updated description.

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/custom-properties/color-type-interpolation.html
(right):

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/color-type-interpolation.html:109:
]);
On 2017/01/25 at 02:55:00, sashab wrote:
> Add test for currentColor as well :^)

Added failing test. Turns out supporting currentcolor is actually non-trivial.

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/2564793002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/interpolation/resources/interpolation-test.js:102:
supportsProperty: function() {return true;},
On 2017/01/25 at 02:55:00, sashab wrote:
> These fixes are great, but maybe put in separate patch.

Done.

[sashab, 2017-01-25 04:35:36]

still lgtm :)

[alancutter (OOO until 2018), 2017-01-25 04:45:49]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-01-25 04:46:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 06:15:37]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485319549341200,
"parent_rev": "1c8ba2ab0aa250ebfcc1c82fb6f6158d71a43b85", "commit_rev":
"96bee2c42c8df73523e971850215d29d1c40c15f"}

[commit-bot: I haz the power, 2017-01-25 06:16:25]

Description was changed from

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.

This does not add support for CSS Transitions, only CSS
Animations and Web Animations.
This does not add support for currentcolor for CSS Animations,
supporting this may require further redesigns to style resolution.

BUG=671904
==========

to

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.

This does not add support for CSS Transitions, only CSS
Animations and Web Animations.
This does not add support for currentcolor for CSS Animations,
supporting this may require further redesigns to style resolution.

BUG=671904

Review-Url: https://codereview.chromium.org/2564793002
Cr-Commit-Position: refs/heads/master@{#445967}
Committed:
https://chromium.googlesource.com/chromium/src/+/96bee2c42c8df73523e971850215...
==========

[commit-bot: I haz the power, 2017-01-25 06:16:26]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/96bee2c42c8df73523e971850215...

[sof, 2017-01-25 10:46:00]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2649103008/ by sigbjornf@opera.com.

The reason for reverting is: Added test is seen failing on the bots, e.g.,


https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...
.

[alancutter (OOO until 2018), 2017-01-28 06:57:16]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 06:57:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 07:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 07:05:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2017-01-28 07:45:51]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 07:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 09:11:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 09:11:43]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2017-01-28 09:23:28]

On 2017/01/25 at 10:46:00, sigbjornf wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2649103008/ by sigbjornf@opera.com.
> 
> The reason for reverting is: Added test is seen failing on the bots, e.g.,
> 
> 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...
> 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...
> .

Very strange, it passed just fine on the try bots but for some reason on the
chromium.webkit builders it was failing the inherit test.
Going to try again to see if they really are behaving differently and revert
again if so.

[alancutter (OOO until 2018), 2017-01-28 09:23:37]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-28 09:23:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2564793002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-28 09:23:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 09:27:33]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485595417331810,
"parent_rev": "d8c814f5c00623af6fbbe7c13cdfbc827c03956d", "commit_rev":
"b2f66c7a95b2d366e8972efc5acac53d60f4978d"}

[commit-bot: I haz the power, 2017-01-28 09:28:12]

Description was changed from

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.

This does not add support for CSS Transitions, only CSS
Animations and Web Animations.
This does not add support for currentcolor for CSS Animations,
supporting this may require further redesigns to style resolution.

BUG=671904

Review-Url: https://codereview.chromium.org/2564793002
Cr-Commit-Position: refs/heads/master@{#445967}
Committed:
https://chromium.googlesource.com/chromium/src/+/96bee2c42c8df73523e971850215...
==========

to

==========
Add smooth interpolation support for <color> custom properties

This change enables smooth interpolation for animations on
custom properties registered as <color>.

This does not add support for CSS Transitions, only CSS
Animations and Web Animations.
This does not add support for currentcolor for CSS Animations,
supporting this may require further redesigns to style resolution.

BUG=671904

Review-Url: https://codereview.chromium.org/2564793002
Cr-Original-Commit-Position: refs/heads/master@{#445967}
Committed:
https://chromium.googlesource.com/chromium/src/+/96bee2c42c8df73523e971850215...
Review-Url: https://codereview.chromium.org/2564793002
Cr-Commit-Position: refs/heads/master@{#446919}
Committed:
https://chromium.googlesource.com/chromium/src/+/b2f66c7a95b2d366e8972efc5aca...
==========

[commit-bot: I haz the power, 2017-01-28 09:28:14]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/b2f66c7a95b2d366e8972efc5aca...

[alancutter (OOO until 2018), 2017-01-28 10:29:51]

On 2017/01/28 at 09:23:28, alancutter wrote:
> On 2017/01/25 at 10:46:00, sigbjornf wrote:
> > A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2649103008/ by sigbjornf@opera.com.
> > 
> > The reason for reverting is: Added test is seen failing on the bots, e.g.,
> > 
> > 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...
> > 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...
> > .
> 
> Very strange, it passed just fine on the try bots but for some reason on the
chromium.webkit builders it was failing the inherit test.
> Going to try again to see if they really are behaving differently and revert
again if so.

Looks like it passes now:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...