Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/animation/CSSInterpolationType.h

Issue 2630503002: Add code path for registered custom properties in CSSInterpolationType (Closed)
Patch Set: Moar buttons Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSInterpolationType.h
diff --git a/third_party/WebKit/Source/core/animation/CSSInterpolationType.h b/third_party/WebKit/Source/core/animation/CSSInterpolationType.h
index 1094c973a2fe2c8f4df7734e7ca096ab8a39ab1a..f97a21d0ee9dc63bbbf489eb9eaf910fa4bdc661 100644
--- a/third_party/WebKit/Source/core/animation/CSSInterpolationType.h
+++ b/third_party/WebKit/Source/core/animation/CSSInterpolationType.h
@@ -10,6 +10,8 @@
namespace blink {
+class CSSCustomPropertyDeclaration;
+
class CSSInterpolationType : public InterpolationType {
protected:
CSSInterpolationType(PropertyHandle);
@@ -50,6 +52,29 @@ class CSSInterpolationType : public InterpolationType {
const InterpolationEnvironment&,
const InterpolationValue& underlying,
ConversionCheckers&) const;
+
+ InterpolationValue maybeConvertCustomPropertyDeclaration(
+ const CSSCustomPropertyDeclaration&,
+ const StyleResolverState&,
+ ConversionCheckers&) const;
+ InterpolationValue maybeConvertCustomPropertyDeclarationInternal(
+ const CSSCustomPropertyDeclaration&,
+ const StyleResolverState&,
+ ConversionCheckers&) const;
+
+ virtual const CSSValue* createCSSValue(const InterpolableValue&,
+ const NonInterpolableValue*,
+ const StyleResolverState&) const {
+ // TODO(alancutter): Implement this for all subclasses and make this an
+ // abstract declaration so the return type can be changed to
+ // const CSSValue&.
+ NOTREACHED();
+ return nullptr;
+ }
+
+ void applyCustomPropertyValue(const InterpolableValue&,
+ const NonInterpolableValue*,
+ StyleResolverState&) const;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698