Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2628323003: [debugger] Use PropertyKind instead of PropertyType. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Use PropertyKind instead of PropertyType. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2628323003 Cr-Commit-Position: refs/heads/master@{#42360} Committed: https://chromium.googlesource.com/v8/v8/+/c6f0de8dd63a58c7a96c774ec43c7cdd4ad78e7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M src/debug/mirrors.js View 4 chunks +6 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-13 14:19:41 UTC) #4
Yang
On 2017/01/13 14:19:41, Igor Sheludko wrote: > PTAL lgtm if layout tests pass (I already ...
3 years, 11 months ago (2017-01-16 08:36:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628323003/1
3 years, 11 months ago (2017-01-16 10:17:55 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 10:48:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c6f0de8dd63a58c7a96c774ec43c7cdd4ad...

Powered by Google App Engine
This is Rietveld 408576698