Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 2628323003: [debugger] Use PropertyKind instead of PropertyType. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/debug/debug-evaluate.h" 9 #include "src/debug/debug-evaluate.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 384
385 DCHECK_EQ(2, args.length()); 385 DCHECK_EQ(2, args.length());
386 386
387 CONVERT_ARG_HANDLE_CHECKED(Object, obj, 0); 387 CONVERT_ARG_HANDLE_CHECKED(Object, obj, 0);
388 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1); 388 CONVERT_ARG_HANDLE_CHECKED(Name, name, 1);
389 389
390 LookupIterator it(obj, name); 390 LookupIterator it(obj, name);
391 return *DebugGetProperty(&it); 391 return *DebugGetProperty(&it);
392 } 392 }
393 393
394 394 // Return the property kind calculated from the property details.
395 // Return the property type calculated from the property details.
396 // args[0]: smi with property details. 395 // args[0]: smi with property details.
397 RUNTIME_FUNCTION(Runtime_DebugPropertyTypeFromDetails) { 396 RUNTIME_FUNCTION(Runtime_DebugPropertyKindFromDetails) {
398 SealHandleScope shs(isolate); 397 SealHandleScope shs(isolate);
399 DCHECK_EQ(1, args.length()); 398 DCHECK_EQ(1, args.length());
400 CONVERT_PROPERTY_DETAILS_CHECKED(details, 0); 399 CONVERT_PROPERTY_DETAILS_CHECKED(details, 0);
401 return Smi::FromInt(static_cast<int>(details.type())); 400 return Smi::FromInt(static_cast<int>(details.kind()));
402 } 401 }
403 402
404 403
405 // Return the property attribute calculated from the property details. 404 // Return the property attribute calculated from the property details.
406 // args[0]: smi with property details. 405 // args[0]: smi with property details.
407 RUNTIME_FUNCTION(Runtime_DebugPropertyAttributesFromDetails) { 406 RUNTIME_FUNCTION(Runtime_DebugPropertyAttributesFromDetails) {
408 SealHandleScope shs(isolate); 407 SealHandleScope shs(isolate);
409 DCHECK_EQ(1, args.length()); 408 DCHECK_EQ(1, args.length());
410 CONVERT_PROPERTY_DETAILS_CHECKED(details, 0); 409 CONVERT_PROPERTY_DETAILS_CHECKED(details, 0);
411 return Smi::FromInt(static_cast<int>(details.attributes())); 410 return Smi::FromInt(static_cast<int>(details.attributes()));
(...skipping 1507 matching lines...) Expand 10 before | Expand all | Expand 10 after
1919 } 1918 }
1920 1919
1921 1920
1922 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1921 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1923 UNIMPLEMENTED(); 1922 UNIMPLEMENTED();
1924 return NULL; 1923 return NULL;
1925 } 1924 }
1926 1925
1927 } // namespace internal 1926 } // namespace internal
1928 } // namespace v8 1927 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698