Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: src/debug/mirrors.js

Issue 2628323003: [debugger] Use PropertyKind instead of PropertyType. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/mirrors.js
diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js
index 7f228f6eb704e346dcbcb704ec283dc362e4626e..2713be36b76c9d06fc5fc7c049d5b662b7bff6e3 100644
--- a/src/debug/mirrors.js
+++ b/src/debug/mirrors.js
@@ -223,11 +223,10 @@ function inherits(ctor, superCtor) {
var kMaxProtocolStringLength = 80;
-// A copy of the PropertyType enum from property-details.h
+// A copy of the PropertyKind enum from property-details.h
var PropertyType = {};
-PropertyType.Data = 0;
-PropertyType.DataConstant = 2;
-PropertyType.AccessorConstant = 3;
+PropertyType.Data = 0;
+PropertyType.Accessor = 1;
// Different attributes for a property.
@@ -799,7 +798,7 @@ ObjectMirror.prototype.lookupProperty = function(value) {
// Skip properties which are defined through accessors.
var property = properties[i];
- if (property.propertyType() != PropertyType.AccessorConstant) {
+ if (property.propertyType() == PropertyType.Data) {
if (property.value_ === value.value_) {
return property;
}
@@ -1545,7 +1544,7 @@ PropertyMirror.prototype.attributes = function() {
PropertyMirror.prototype.propertyType = function() {
- return %DebugPropertyTypeFromDetails(this.details_);
+ return %DebugPropertyKindFromDetails(this.details_);
};
@@ -1603,7 +1602,7 @@ PropertyMirror.prototype.setter = function() {
*/
PropertyMirror.prototype.isNative = function() {
return this.is_interceptor_ ||
- ((this.propertyType() == PropertyType.AccessorConstant) &&
+ ((this.propertyType() == PropertyType.Accessor) &&
!this.hasGetter() && !this.hasSetter());
};
« no previous file with comments | « no previous file | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698