Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2629423002: [runtime] Remove PropertyType definition and use PropertyKind/PropertyLocation instead. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove PropertyType definition and use PropertyKind/PropertyLocation instead. Now we can add a constness bit to the PropertyDetails. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2629423002 Cr-Commit-Position: refs/heads/master@{#42366} Committed: https://chromium.googlesource.com/v8/v8/+/8f0bf07b504e8bb27ef3703388c4c0699670331f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -96 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/property-details.h View 3 chunks +0 lines, -20 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 7 chunks +54 lines, -56 lines 0 comments Download
M test/cctest/test-transitions.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (12 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-13 16:03:12 UTC) #6
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-13 17:18:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629423002/20001
3 years, 11 months ago (2017-01-16 11:24:27 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 11:59:24 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8f0bf07b504e8bb27ef3703388c4c069967...

Powered by Google App Engine
This is Rietveld 408576698