DescriptionRevert of Optimize GLES2DecoderImpl::ApplyDirtyState. (https://codereview.chromium.org/245923008/)
Reason for revert:
Failing compile on win64 debug waterfall bot
gpu\command_buffer\service\gles2_cmd_decoder_unittest.cc : fatalerror C1128: number of sections exceeded object file format limit : compile with /bigobj
link: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/7743
Original issue's description:
> Optimize GLES2DecoderImpl::ApplyDirtyState.
>
> ApplyDirtyState can on average 30% of the time of GLES2
> draw calls. It previously set Color, Depth, Stencil masks
> and several enables without checking if they changed.
>
> This change caches values used in ApplyDirtyState among
> other places, and adds ContextState methods for setting
> state with cache checks.
>
> New cached state aware Set methods:
> * ContextState::SetDeviceCapabilityState
> * ContextState::SetDeviceColorMask
> * ContextState::SetDeviceDepthMask
> * ContextState::SetDeviceStencilMaskSeparate
>
> Testing:
> * gpu_unit tests now run both with cache on and off (ignore_cached_state_for_test = true)
> to validate behavior independent of cache layering.
> * New tests specific for caching behavior:
> ** GLES2DecoderManualInitTest.ContextStateCapabilityCaching
> ** GLES2DecoderManualInitTest.CachedColorMask
> ** GLES2DecoderManualInitTest.CachedDepthMask
> ** GLES2DecoderManualInitTest.CachedStencilMask
>
> BUG=347364
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267450
TBR=piman@chromium.org,jbates@chromium.org,oetuaho@nvidia.com,vmiura@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347364
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267465
Patch Set 1 #
Created: 6 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|