Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 262793002: Revert of Optimize GLES2DecoderImpl::ApplyDirtyState. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
Reviewers:
piman, vmiura, jbates, oetuaho-nv
CC:
chromium-reviews, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Optimize GLES2DecoderImpl::ApplyDirtyState. (https://codereview.chromium.org/245923008/) Reason for revert: Failing compile on win64 debug waterfall bot gpu\command_buffer\service\gles2_cmd_decoder_unittest.cc : fatalerror C1128: number of sections exceeded object file format limit : compile with /bigobj link: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/7743 Original issue's description: > Optimize GLES2DecoderImpl::ApplyDirtyState. > > ApplyDirtyState can on average 30% of the time of GLES2 > draw calls. It previously set Color, Depth, Stencil masks > and several enables without checking if they changed. > > This change caches values used in ApplyDirtyState among > other places, and adds ContextState methods for setting > state with cache checks. > > New cached state aware Set methods: > * ContextState::SetDeviceCapabilityState > * ContextState::SetDeviceColorMask > * ContextState::SetDeviceDepthMask > * ContextState::SetDeviceStencilMaskSeparate > > Testing: > * gpu_unit tests now run both with cache on and off (ignore_cached_state_for_test = true) > to validate behavior independent of cache layering. > * New tests specific for caching behavior: > ** GLES2DecoderManualInitTest.ContextStateCapabilityCaching > ** GLES2DecoderManualInitTest.CachedColorMask > ** GLES2DecoderManualInitTest.CachedDepthMask > ** GLES2DecoderManualInitTest.CachedStencilMask > > BUG=347364 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267450 TBR=piman@chromium.org,jbates@chromium.org,oetuaho@nvidia.com,vmiura@chromium.org NOTREECHECKS=true NOTRY=true BUG=347364 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267465

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1207 lines, -1837 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 47 chunks +57 lines, -164 lines 0 comments Download
M gpu/command_buffer/service/context_state.h View 3 chunks +0 lines, -43 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 2 chunks +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/context_state_autogen.h View 4 chunks +0 lines, -74 lines 0 comments Download
M gpu/command_buffer/service/context_state_impl_autogen.h View 8 chunks +48 lines, -76 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 16 chunks +48 lines, -48 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 chunk +13 lines, -47 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 311 chunks +606 lines, -828 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 168 chunks +170 lines, -170 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 2 chunks +15 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 152 chunks +152 lines, -152 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 5 chunks +5 lines, -35 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 8 chunks +90 lines, -172 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Optimize GLES2DecoderImpl::ApplyDirtyState.
6 years, 7 months ago (2014-05-01 07:40:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/262793002/1
6 years, 7 months ago (2014-05-01 07:41:02 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 07:41:58 UTC) #3
Message was sent while issue was closed.
Change committed as 267465

Powered by Google App Engine
This is Rietveld 408576698