gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc - Issue 262793002: Revert of Optimize GLES2DecoderImpl::ApplyDirtyState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

Issue 262793002: Revert of Optimize GLES2DecoderImpl::ApplyDirtyState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

index 3fadaf07634a2c1180010488adc22e69c7ddada0..b41eed2953ad40c59443caf13eb7d563c527c3a1 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc

@@ -34,9 +34,7 @@

GLES2DecoderTest3() { }

};

-INSTANTIATE_TEST_CASE_P(Service, GLES2DecoderTest3, ::testing::Bool());

-TEST_P(GLES2DecoderTest3, TraceBeginCHROMIUM) {

+TEST_F(GLES2DecoderTest3, TraceBeginCHROMIUM) {

const uint32 kBucketId = 123;

const char kName[] = "test_command";

SetBucketAsCString(kBucketId, kName);

@@ -46,7 +44,7 @@

EXPECT_EQ(error::kNoError, ExecuteCmd(begin_cmd));

}

-TEST_P(GLES2DecoderTest3, TraceEndCHROMIUM) {

+TEST_F(GLES2DecoderTest3, TraceEndCHROMIUM) {

// Test end fails if no begin.

TraceEndCHROMIUM end_cmd;

end_cmd.Init();