Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 262753004: Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted] (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, philipj_slow, arv+blink, Rik, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, vcarbune.chromium, feature-media-reviews_chromium.org, dglazkov+blink, nessy, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted] This fixes: * all FIXMEs for the tracking bug (354298) * all occurrences of ExceptionMessages::notAFiniteNumber for IDL type checks (i.e., TypeChecks thrown for all non-finite numbers): - there are cases where it is used for infinite numbers, but not NaN, and - InvalidAccessError but not TypeCheck No change in behavior: just throw exceptions from bindings instead of Blink. Checked all other uses of std::isfinite, and none of them throw exceptions (commented web-exposed ones with spec). Cannot add any more type checks without changing web interface, which has to be done incrementally. R=haraken BUG=354298 TEST=fast/dom/HTMLMeterElement/set-meter-properties.html TEST=fast/dom/HTMLProgressElement/set-progress-properties.html TEST=media/track/regions-webvtt/vtt-region-constructor.html TEST=media/track/text-track-cue-exceptions.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173170

Patch Set 1 #

Patch Set 2 : Remove unnecessary code (std::isfinite not needed for long) #

Total comments: 1

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -192 lines) Patch
M LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt View 1 2 1 chunk +15 lines, -15 lines 0 comments Download
M LayoutTests/media/track/text-track-cue-exceptions.html View 1 2 1 chunk +12 lines, -17 lines 0 comments Download
M LayoutTests/media/track/text-track-cue-exceptions-expected.txt View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M Source/core/html/HTMLMeterElement.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 4 chunks +16 lines, -40 lines 0 comments Download
M Source/core/html/HTMLMeterElement.idl View 1 chunk +11 lines, -7 lines 0 comments Download
M Source/core/html/HTMLProgressElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/html/HTMLProgressElement.idl View 1 chunk +9 lines, -6 lines 0 comments Download
M Source/core/html/MediaController.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrackCue.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 3 chunks +2 lines, -19 lines 0 comments Download
M Source/core/html/track/TextTrackCue.idl View 1 chunk +10 lines, -7 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/track/vtt/VTTRegion.cpp View 6 chunks +6 lines, -10 lines 0 comments Download
M Source/core/html/track/vtt/VTTRegion.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Nils Barth (inactive)
Last one for unrestricted!
6 years, 7 months ago (2014-05-01 06:37:38 UTC) #1
Nils Barth (inactive)
https://codereview.chromium.org/262753004/diff/10001/Source/core/html/track/vtt/VTTCue.cpp File Source/core/html/track/vtt/VTTCue.cpp (right): https://codereview.chromium.org/262753004/diff/10001/Source/core/html/track/vtt/VTTCue.cpp#newcode118 Source/core/html/track/vtt/VTTCue.cpp:118: static bool isInvalidPercentage(int value, ExceptionState& exceptionState) This is only ...
6 years, 7 months ago (2014-05-01 07:42:32 UTC) #2
haraken
This looks great! LGTM.
6 years, 7 months ago (2014-05-01 07:46:32 UTC) #3
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-01 07:48:08 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 7 months ago (2014-05-01 07:48:11 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-01 08:06:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/262753004/10001
6 years, 7 months ago (2014-05-01 08:06:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 08:12:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-05-01 08:12:47 UTC) #9
Nils Barth (inactive)
Phil fixed some others: Use [TypeChecking=Unrestricted] for HTMLMediaElement https://codereview.chromium.org/261783009/ Use [TypeChecking=Unrestricted] for MediaController https://codereview.chromium.org/265743010/ ...so ...
6 years, 7 months ago (2014-05-02 01:10:08 UTC) #10
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-02 01:27:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/262753004/30001
6 years, 7 months ago (2014-05-02 01:27:30 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 01:35:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink
6 years, 7 months ago (2014-05-02 01:35:13 UTC) #14
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-02 02:33:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/262753004/30001
6 years, 7 months ago (2014-05-02 02:34:07 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 02:44:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink
6 years, 7 months ago (2014-05-02 02:44:29 UTC) #18
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-02 03:09:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/262753004/50001
6 years, 7 months ago (2014-05-02 03:10:03 UTC) #20
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 04:16:34 UTC) #21
Message was sent while issue was closed.
Change committed as 173170

Powered by Google App Engine
This is Rietveld 408576698