Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: Source/core/html/track/TextTrackCue.cpp

Issue 262753004: Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/TextTrackCue.h ('k') | Source/core/html/track/TextTrackCue.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.cpp
diff --git a/Source/core/html/track/TextTrackCue.cpp b/Source/core/html/track/TextTrackCue.cpp
index 483fb389152a4b293e0ab7f22aa3433ce0170fdf..cc0ea31ccf38d7982fccebe13ed981cd5ab0c26b 100644
--- a/Source/core/html/track/TextTrackCue.cpp
+++ b/Source/core/html/track/TextTrackCue.cpp
@@ -42,15 +42,6 @@ namespace WebCore {
static const int invalidCueIndex = -1;
-bool TextTrackCue::isInfiniteOrNonNumber(double value, ExceptionState& exceptionState)
-{
- if (!std::isfinite(value)) {
- exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(value));
- return true;
- }
- return false;
-}
-
TextTrackCue::TextTrackCue(double start, double end)
: m_startTime(start)
, m_endTime(end)
@@ -98,12 +89,8 @@ void TextTrackCue::setId(const AtomicString& id)
cueDidChange();
}
-void TextTrackCue::setStartTime(double value, ExceptionState& exceptionState)
+void TextTrackCue::setStartTime(double value)
{
- // NaN, Infinity and -Infinity values should trigger a TypeError.
- if (isInfiniteOrNonNumber(value, exceptionState))
- return;
-
// TODO(93143): Add spec-compliant behavior for negative time values.
if (m_startTime == value || value < 0)
return;
@@ -113,12 +100,8 @@ void TextTrackCue::setStartTime(double value, ExceptionState& exceptionState)
cueDidChange();
}
-void TextTrackCue::setEndTime(double value, ExceptionState& exceptionState)
+void TextTrackCue::setEndTime(double value)
{
- // NaN, Infinity and -Infinity values should trigger a TypeError.
- if (isInfiniteOrNonNumber(value, exceptionState))
- return;
-
// TODO(93143): Add spec-compliant behavior for negative time values.
if (m_endTime == value || value < 0)
return;
« no previous file with comments | « Source/core/html/track/TextTrackCue.h ('k') | Source/core/html/track/TextTrackCue.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698