Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: Source/modules/mediasource/SourceBuffer.cpp

Issue 262753004: Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTRegion.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediasource/SourceBuffer.cpp
diff --git a/Source/modules/mediasource/SourceBuffer.cpp b/Source/modules/mediasource/SourceBuffer.cpp
index cfbd6c09d7a709f1ce774f1bbb73d16aa6e122e4..2aad22c7ee09a278971a40b460a1114ba9531cf9 100644
--- a/Source/modules/mediasource/SourceBuffer.cpp
+++ b/Source/modules/mediasource/SourceBuffer.cpp
@@ -244,12 +244,12 @@ void SourceBuffer::setAppendWindowEnd(double end, ExceptionState& exceptionState
return;
// 3. If the new value equals NaN, then throw an InvalidAccessError and abort these steps.
- // 4. If the new value is less than or equal to appendWindowStart then throw an InvalidAccessError
- // exception and abort these steps.
if (std::isnan(end)) {
exceptionState.throwDOMException(InvalidAccessError, ExceptionMessages::notAFiniteNumber(end));
return;
}
+ // 4. If the new value is less than or equal to appendWindowStart then throw an InvalidAccessError
+ // exception and abort these steps.
if (end <= m_appendWindowStart) {
// FIXME: Use ExceptionState::indexExceedsMinimumBound() once it lands.
exceptionState.throwDOMException(InvalidAccessError, "The value provided ('" + String::number(end) + "') is less than or equal to the minimum value (" + String::number(m_appendWindowStart) + ").");
« no previous file with comments | « Source/core/html/track/vtt/VTTRegion.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698