|
Replace all remaining IDL finitude type checks with [TypeChecking=Unrestricted]
This fixes:
* all FIXMEs for the tracking bug (354298)
* all occurrences of ExceptionMessages::notAFiniteNumber for IDL type checks
(i.e., TypeChecks thrown for all non-finite numbers):
- there are cases where it is used for infinite numbers, but not NaN, and
- InvalidAccessError but not TypeCheck
No change in behavior: just throw exceptions from bindings instead of Blink.
Checked all other uses of std::isfinite, and none of them throw exceptions
(commented web-exposed ones with spec).
Cannot add any more type checks without changing web interface, which has to
be done incrementally.
R=haraken
BUG= 354298
TEST=fast/dom/HTMLMeterElement/set-meter-properties.html
TEST=fast/dom/HTMLProgressElement/set-progress-properties.html
TEST=media/track/regions-webvtt/vtt-region-constructor.html
TEST=media/track/text-track-cue-exceptions.html
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173170
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+155 lines, -192 lines) |
Patch |
 |
M |
LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js
|
View
|
1
2
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/HTMLMeterElement/set-meter-properties-expected.txt
|
View
|
1
2
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js
|
View
|
1
2
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/dom/HTMLProgressElement/set-progress-properties-expected.txt
|
View
|
1
2
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt
|
View
|
1
2
|
1 chunk |
+15 lines, -15 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/media/track/text-track-cue-exceptions.html
|
View
|
1
2
|
1 chunk |
+12 lines, -17 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/media/track/text-track-cue-exceptions-expected.txt
|
View
|
1
2
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLInputElement.cpp
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLInputElement.idl
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLMediaElement.cpp
|
View
|
1
2
|
2 chunks |
+11 lines, -9 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLMeterElement.h
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLMeterElement.cpp
|
View
|
|
4 chunks |
+16 lines, -40 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLMeterElement.idl
|
View
|
|
1 chunk |
+11 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLProgressElement.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLProgressElement.cpp
|
View
|
|
1 chunk |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/HTMLProgressElement.idl
|
View
|
|
1 chunk |
+9 lines, -6 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/MediaController.idl
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/canvas/WebGLRenderingContextBase.idl
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/track/TextTrackCue.h
|
View
|
1
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/track/TextTrackCue.cpp
|
View
|
|
3 chunks |
+2 lines, -19 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/track/TextTrackCue.idl
|
View
|
|
1 chunk |
+10 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/track/vtt/VTTCue.cpp
|
View
|
1
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/track/vtt/VTTRegion.cpp
|
View
|
|
6 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
 |
M |
Source/core/html/track/vtt/VTTRegion.idl
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
Source/modules/mediasource/SourceBuffer.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 21 (0 generated)
|