DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module

DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module

BUG=none

Review-Url: https://codereview.chromium.org/2626173002
Cr-Commit-Position: refs/heads/master@{#443143}
Committed: https://chromium.googlesource.com/chromium/src/+/f42add702e5cbf42601dd53e27456ca0ec747c27

[chenwilliam, 2017-01-11 22:38:38]

chenwilliam@chromium.org changed reviewers:
+ pfeldman@chromium.org

[chenwilliam, 2017-01-11 22:38:39]

PTAL. Mapping of identifiers:

  'Profiler.HeapSnapshotProgressEvent' =>
'HeapSnapshotModel.HeapSnapshotProgressEvent',
  'Profiler.HeapSnapshotCommon = {};\n\n' => '',
  'Profiler.HeapSnapshotCommon.baseSystemDistance' =>
'HeapSnapshotModel.baseSystemDistance',
  'Profiler.HeapSnapshotCommon.AllocationNodeCallers' =>
'HeapSnapshotModel.AllocationNodeCallers',
  'Profiler.HeapSnapshotCommon.SerializedAllocationNode' =>
'HeapSnapshotModel.SerializedAllocationNode',
  'Profiler.HeapSnapshotCommon.AllocationStackFrame' =>
'HeapSnapshotModel.AllocationStackFrame',
  'Profiler.HeapSnapshotCommon.Node' => 'HeapSnapshotModel.Node',
  'Profiler.HeapSnapshotCommon.Edge' => 'HeapSnapshotModel.Edge',
  'Profiler.HeapSnapshotCommon.Aggregate' => 'HeapSnapshotModel.Aggregate',
  'Profiler.HeapSnapshotCommon.AggregateForDiff' =>
'HeapSnapshotModel.AggregateForDiff',
  'Profiler.HeapSnapshotCommon.Diff' => 'HeapSnapshotModel.Diff',
  'Profiler.HeapSnapshotCommon.DiffForClass' =>
'HeapSnapshotModel.DiffForClass',
  'Profiler.HeapSnapshotCommon.ComparatorConfig' =>
'HeapSnapshotModel.ComparatorConfig',
  'Profiler.HeapSnapshotCommon.WorkerCommand' =>
'HeapSnapshotModel.WorkerCommand',
  'Profiler.HeapSnapshotCommon.ItemsRange' => 'HeapSnapshotModel.ItemsRange',
  'Profiler.HeapSnapshotCommon.StaticData' => 'HeapSnapshotModel.StaticData',
  'Profiler.HeapSnapshotCommon.Statistics' => 'HeapSnapshotModel.Statistics',
  'Profiler.HeapSnapshotCommon.NodeFilter' => 'HeapSnapshotModel.NodeFilter',
  'Profiler.HeapSnapshotCommon.SearchConfig' =>
'HeapSnapshotModel.SearchConfig',
  'Profiler.HeapSnapshotCommon.Samples' => 'HeapSnapshotModel.Samples'

[pfeldman, 2017-01-11 23:01:42]

lgtm % comment

https://codereview.chromium.org/2626173002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/2626173002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/BUILD.gn:238:
"front_end/heap_snapshot_model/HeapSnapshotModel.js",
it needs to have a module.json

[chenwilliam, 2017-01-11 23:41:59]

https://codereview.chromium.org/2626173002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/BUILD.gn (right):

https://codereview.chromium.org/2626173002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/BUILD.gn:238:
"front_end/heap_snapshot_model/HeapSnapshotModel.js",
On 2017/01/11 23:01:42, pfeldman wrote:
> it needs to have a module.json

done. I added it for all the new modules I made recently (and updated the
extract_module script).

[chenwilliam, 2017-01-11 23:42:03]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-01-11 23:42:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2626173002/#ps20001
(title: "add module.json for modules")

[commit-bot: I haz the power, 2017-01-11 23:42:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:55:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484178123746620,
"parent_rev": "20d9207c7997b8d0d2a978032e25a3a4274a9f5f", "commit_rev":
"f42add702e5cbf42601dd53e27456ca0ec747c27"}

[commit-bot: I haz the power, 2017-01-12 03:56:26]

Description was changed from

==========
DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module

BUG=none
==========

to

==========
DevTools: Extract HeapSnapshotCommon.js into HeapSnapshotModel module

BUG=none

Review-Url: https://codereview.chromium.org/2626173002
Cr-Commit-Position: refs/heads/master@{#443143}
Committed:
https://chromium.googlesource.com/chromium/src/+/f42add702e5cbf42601dd53e2745...
==========

[commit-bot: I haz the power, 2017-01-12 03:56:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f42add702e5cbf42601dd53e2745...